Remove branch condition which is always true

Change-Id: I27385061986f7b43f78365278fa763c70a451b46
This commit is contained in:
Sho SHIMIZU 2015-10-27 11:38:37 -07:00 committed by Gerrit Code Review
parent 08105be3e6
commit 0fa6d3b745

View File

@ -191,7 +191,6 @@ public class VirtualPortManager implements VirtualPortService {
@Override @Override
public boolean updatePorts(Iterable<VirtualPort> vPorts) { public boolean updatePorts(Iterable<VirtualPort> vPorts) {
checkNotNull(vPorts, VIRTUALPORT_NOT_NULL); checkNotNull(vPorts, VIRTUALPORT_NOT_NULL);
if (vPorts != null) {
for (VirtualPort vPort : vPorts) { for (VirtualPort vPort : vPorts) {
vPortStore.put(vPort.portId(), vPort); vPortStore.put(vPort.portId(), vPort);
if (!vPortStore.containsKey(vPort.portId())) { if (!vPortStore.containsKey(vPort.portId())) {
@ -208,14 +207,12 @@ public class VirtualPortManager implements VirtualPortService {
return false; return false;
} }
} }
}
return true; return true;
} }
@Override @Override
public boolean removePorts(Iterable<VirtualPortId> vPortIds) { public boolean removePorts(Iterable<VirtualPortId> vPortIds) {
checkNotNull(vPortIds, VIRTUALPORT_ID_NULL); checkNotNull(vPortIds, VIRTUALPORT_ID_NULL);
if (vPortIds != null) {
for (VirtualPortId vPortId : vPortIds) { for (VirtualPortId vPortId : vPortIds) {
vPortStore.remove(vPortId); vPortStore.remove(vPortId);
if (vPortStore.containsKey(vPortId)) { if (vPortStore.containsKey(vPortId)) {
@ -224,7 +221,6 @@ public class VirtualPortManager implements VirtualPortService {
return false; return false;
} }
} }
}
return true; return true;
} }