diff --git a/core/api/src/main/java/org/onosproject/net/edge/EdgePortService.java b/core/api/src/main/java/org/onosproject/net/edge/EdgePortService.java index 44e4b66789..94ab611235 100644 --- a/core/api/src/main/java/org/onosproject/net/edge/EdgePortService.java +++ b/core/api/src/main/java/org/onosproject/net/edge/EdgePortService.java @@ -45,6 +45,7 @@ public interface EdgePortService { /** * Returns a collection of all edge point for the specified device. * + * @param deviceId device identifier * @return iterable collection of all edge points for the device */ Iterable getEdgePoint(DeviceId deviceId); diff --git a/core/api/src/main/java/org/onosproject/net/flowobjective/ObjectiveContext.java b/core/api/src/main/java/org/onosproject/net/flowobjective/ObjectiveContext.java index c6db17fe69..f3d23e4aee 100644 --- a/core/api/src/main/java/org/onosproject/net/flowobjective/ObjectiveContext.java +++ b/core/api/src/main/java/org/onosproject/net/flowobjective/ObjectiveContext.java @@ -39,6 +39,7 @@ public interface ObjectiveContext { * Invoked when error is encountered while executing the flow objective. * * @param objective objective to execute + * @param error error encountered */ default void onError(Objective objective, ObjectiveError error) { } diff --git a/core/api/src/main/java/org/onosproject/store/service/Versioned.java b/core/api/src/main/java/org/onosproject/store/service/Versioned.java index fb6a78bc63..f0e70bdda3 100644 --- a/core/api/src/main/java/org/onosproject/store/service/Versioned.java +++ b/core/api/src/main/java/org/onosproject/store/service/Versioned.java @@ -91,6 +91,7 @@ public class Versioned { * Maps this instance into another after transforming its * value while retaining the same version and creationTime. * @param transformer function to mapping the value + * @param value type of the returned instance * @return mapped instance */ public Versioned map(Function transformer) { diff --git a/core/store/dist/src/main/java/org/onosproject/store/consistent/impl/TransactionManager.java b/core/store/dist/src/main/java/org/onosproject/store/consistent/impl/TransactionManager.java index 245ae1a141..16e1cdc1c8 100644 --- a/core/store/dist/src/main/java/org/onosproject/store/consistent/impl/TransactionManager.java +++ b/core/store/dist/src/main/java/org/onosproject/store/consistent/impl/TransactionManager.java @@ -59,6 +59,7 @@ public class TransactionManager { * Constructs a new TransactionManager for the specified database instance. * * @param database database + * @param mapBuilder builder for ConsistentMap instances */ public TransactionManager(Database database, ConsistentMapBuilder mapBuilder) { this.database = checkNotNull(database, "database cannot be null"); diff --git a/web/api/src/main/java/org/onosproject/rest/resources/FlowsWebResource.java b/web/api/src/main/java/org/onosproject/rest/resources/FlowsWebResource.java index 260a2b9939..f77bb43743 100644 --- a/web/api/src/main/java/org/onosproject/rest/resources/FlowsWebResource.java +++ b/web/api/src/main/java/org/onosproject/rest/resources/FlowsWebResource.java @@ -129,6 +129,7 @@ public class FlowsWebResource extends AbstractWebResource { /** * Creates a flow rule from a POST of a JSON string and attempts to apply it. * + * @param deviceId device identifier * @param stream input JSON * @return status of the request - CREATED if the JSON is correct, * BAD_REQUEST if the JSON is invalid