From 067c44bcbabcdf966908b19f82fcd5cbe13707bf Mon Sep 17 00:00:00 2001
From: Ray Milkey <ray@opennetworking.org>
Date: Mon, 26 Feb 2018 12:48:23 -0800
Subject: [PATCH] Fix SONAR problems

Change-Id: Id79866971b7b2c894babe45a69f22f44cf3584db
---
 .../onosproject/segmentrouting/pwaas/L2TunnelHandler.java   | 2 +-
 .../org/onosproject/drivers/server/BasicServerDriver.java   | 2 +-
 .../onosproject/drivers/server/ServerDevicesDiscovery.java  | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/apps/segmentrouting/app/src/main/java/org/onosproject/segmentrouting/pwaas/L2TunnelHandler.java b/apps/segmentrouting/app/src/main/java/org/onosproject/segmentrouting/pwaas/L2TunnelHandler.java
index 3a89a213c8..044ad416ac 100644
--- a/apps/segmentrouting/app/src/main/java/org/onosproject/segmentrouting/pwaas/L2TunnelHandler.java
+++ b/apps/segmentrouting/app/src/main/java/org/onosproject/segmentrouting/pwaas/L2TunnelHandler.java
@@ -129,7 +129,7 @@ public interface L2TunnelHandler {
 
         private final int code;
         private final String description;
-        public int nextId;
+        protected int nextId;
 
         Result(int code, String description) {
             this.code = code;
diff --git a/drivers/server/src/main/java/org/onosproject/drivers/server/BasicServerDriver.java b/drivers/server/src/main/java/org/onosproject/drivers/server/BasicServerDriver.java
index fa8ee63736..ba16a3a23e 100644
--- a/drivers/server/src/main/java/org/onosproject/drivers/server/BasicServerDriver.java
+++ b/drivers/server/src/main/java/org/onosproject/drivers/server/BasicServerDriver.java
@@ -160,7 +160,7 @@ public class BasicServerDriver extends AbstractHandlerBehaviour {
         try {
             result = jsonNode.get(attribute).asText();
         } catch (Exception ex) {
-            throw new RuntimeException(
+            throw new IllegalArgumentException(
                 "Failed to read JSON attribute: " + attribute
             );
         }
diff --git a/drivers/server/src/main/java/org/onosproject/drivers/server/ServerDevicesDiscovery.java b/drivers/server/src/main/java/org/onosproject/drivers/server/ServerDevicesDiscovery.java
index 3adb0b41b3..694320d963 100644
--- a/drivers/server/src/main/java/org/onosproject/drivers/server/ServerDevicesDiscovery.java
+++ b/drivers/server/src/main/java/org/onosproject/drivers/server/ServerDevicesDiscovery.java
@@ -305,7 +305,7 @@ public class ServerDevicesDiscovery extends BasicServerDriver
             String portTypeStr = get(nn, NIC_PARAM_PORT_TYPE);
             Port.Type portType = PORT_TYPE_MAP.get(portTypeStr);
             if (portType == null) {
-                throw new RuntimeException(
+                throw new IllegalArgumentException(
                     portTypeStr + " is not a valid port type for NIC " + nicId
                 );
             }
@@ -313,7 +313,7 @@ public class ServerDevicesDiscovery extends BasicServerDriver
             String hwAddr      = get(nn, NIC_PARAM_HW_ADDR);
             JsonNode tagNode   = nicObjNode.path(NIC_PARAM_RX_FILTER);
             if (tagNode == null) {
-                throw new RuntimeException(
+                throw new IllegalArgumentException(
                     "The Rx filters of NIC " + nicId + " are not reported"
                 );
             }
@@ -723,7 +723,7 @@ public class ServerDevicesDiscovery extends BasicServerDriver
 
         // And verify that this is the traffic class we want to monitor
         if (!id.equals(tcId.toString())) {
-            throw new RuntimeException(
+            throw new IllegalStateException(
                 "Failed to retrieve monitoring data for traffic class " + tcId +
                 ". Traffic class ID does not agree."
             );