mirror of
https://github.com/siderolabs/omni.git
synced 2025-08-09 11:06:59 +02:00
Some checks are pending
default / default (push) Waiting to run
default / e2e-backups (push) Blocked by required conditions
default / e2e-forced-removal (push) Blocked by required conditions
default / e2e-scaling (push) Blocked by required conditions
default / e2e-short (push) Blocked by required conditions
default / e2e-short-secureboot (push) Blocked by required conditions
default / e2e-templates (push) Blocked by required conditions
default / e2e-upgrades (push) Blocked by required conditions
default / e2e-workload-proxy (push) Blocked by required conditions
The test was flaky - in some rare cases, the create/update times were not set as expected. Fix it, simplify and speed up the test using the new `synctest` experiment. Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
260 lines
7.4 KiB
Go
260 lines
7.4 KiB
Go
// Copyright (c) 2025 Sidero Labs, Inc.
|
|
//
|
|
// Use of this software is governed by the Business Source License
|
|
// included in the LICENSE file.
|
|
|
|
package resourcelogger_test
|
|
|
|
import (
|
|
"context"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
"testing/synctest"
|
|
"time"
|
|
|
|
"github.com/cosi-project/runtime/pkg/state"
|
|
"github.com/cosi-project/runtime/pkg/state/impl/inmem"
|
|
"github.com/cosi-project/runtime/pkg/state/impl/namespaced"
|
|
"github.com/cosi-project/runtime/pkg/state/registry"
|
|
"github.com/siderolabs/gen/xslices"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
"go.uber.org/zap"
|
|
"go.uber.org/zap/zapcore"
|
|
"go.uber.org/zap/zaptest/observer"
|
|
"golang.org/x/sync/errgroup"
|
|
|
|
"github.com/siderolabs/omni/client/api/omni/specs"
|
|
"github.com/siderolabs/omni/client/pkg/omni/resources"
|
|
"github.com/siderolabs/omni/client/pkg/omni/resources/omni"
|
|
resourceregistry "github.com/siderolabs/omni/client/pkg/omni/resources/registry"
|
|
"github.com/siderolabs/omni/internal/backend/resourcelogger"
|
|
)
|
|
|
|
func TestResourceLogger(t *testing.T) {
|
|
t.Setenv("TZ", "UTC")
|
|
|
|
synctest.Run(func() {
|
|
ctx, cancel := context.WithCancel(t.Context())
|
|
defer cancel()
|
|
|
|
st := state.WrapCore(namespaced.NewState(inmem.Build))
|
|
resourceRegistry := registry.NewResourceRegistry(st)
|
|
|
|
for _, r := range resourceregistry.Resources {
|
|
require.NoError(t, resourceRegistry.Register(ctx, r))
|
|
}
|
|
|
|
machineStatus := omni.NewMachineStatus(resources.DefaultNamespace, "test")
|
|
cbs := omni.NewClusterBootstrapStatus(resources.DefaultNamespace, "test")
|
|
cp := omni.NewConfigPatch(resources.DefaultNamespace, "test")
|
|
|
|
logObserverCore, observedLogs := observer.New(zapcore.InfoLevel)
|
|
|
|
logger := zap.New(logObserverCore)
|
|
|
|
resLogger, err := resourcelogger.New(ctx, st, logger, zapcore.WarnLevel.String(), "machinestatus", "cbs", "configpatches")
|
|
require.NoError(t, err)
|
|
|
|
require.NoError(t, resLogger.StartWatches(ctx))
|
|
|
|
var eg errgroup.Group
|
|
|
|
defer func() {
|
|
cancel()
|
|
|
|
require.NoError(t, eg.Wait())
|
|
}()
|
|
|
|
eg.Go(func() error { return resLogger.StartLogger(ctx) })
|
|
|
|
machineStatus.TypedSpec().Value.Cluster = "some-cluster"
|
|
machineStatus.TypedSpec().Value.ManagementAddress = "some-address"
|
|
machineStatus.TypedSpec().Value.TalosVersion = "v1.2.3"
|
|
machineStatus.TypedSpec().Value.Role = specs.MachineStatusSpec_WORKER
|
|
machineStatus.TypedSpec().Value.Network = &specs.MachineStatusSpec_NetworkStatus{
|
|
Hostname: "aaa",
|
|
Domainname: "bbb",
|
|
Addresses: []string{"1.2.3.4", "5.6.7.8"},
|
|
DefaultGateways: []string{"2.3.4.5"},
|
|
NetworkLinks: []*specs.MachineStatusSpec_NetworkStatus_NetworkLinkStatus{
|
|
{
|
|
LinuxName: "linux-name",
|
|
HardwareAddress: "hw-address",
|
|
SpeedMbps: 1234,
|
|
LinkUp: true,
|
|
Description: "hello",
|
|
},
|
|
},
|
|
}
|
|
cbs.TypedSpec().Value.Bootstrapped = false
|
|
|
|
err = cp.TypedSpec().Value.SetUncompressedData([]byte("some data"))
|
|
require.NoError(t, err)
|
|
|
|
require.NoError(t, st.Create(ctx, machineStatus))
|
|
require.NoError(t, st.Create(ctx, cbs))
|
|
require.NoError(t, st.Create(ctx, cp))
|
|
|
|
machineStatus.TypedSpec().Value.Cluster = "some-cluster-updated"
|
|
machineStatus.TypedSpec().Value.ManagementAddress = "some-address-updated"
|
|
machineStatus.TypedSpec().Value.Network.Domainname = "ccc"
|
|
cbs.TypedSpec().Value.Bootstrapped = true
|
|
|
|
err = cp.TypedSpec().Value.SetUncompressedData([]byte("some data updated"))
|
|
require.NoError(t, err)
|
|
|
|
// sleep for a second, so the update time will differ from the creation time
|
|
time.Sleep(time.Second)
|
|
|
|
require.NoError(t, st.Update(ctx, machineStatus))
|
|
require.NoError(t, st.Update(ctx, cbs))
|
|
require.NoError(t, st.Update(ctx, cp))
|
|
|
|
require.NoError(t, st.Destroy(ctx, machineStatus.Metadata()))
|
|
require.NoError(t, st.Destroy(ctx, cbs.Metadata()))
|
|
require.NoError(t, st.Destroy(ctx, cp.Metadata()))
|
|
|
|
// wait a bit for the logs to be observed
|
|
time.Sleep(3 * time.Second)
|
|
|
|
entries := xslices.Map(observedLogs.All(), func(entry observer.LoggedEntry) logEntry {
|
|
return parseLogEntry(t, entry)
|
|
})
|
|
|
|
assert.ElementsMatch(t, entries, []logEntry{
|
|
{
|
|
message: "resource created",
|
|
resource: "ClusterBootstrapStatuses.omni.sidero.dev(default/test@1)",
|
|
},
|
|
{
|
|
message: "resource created",
|
|
resource: "MachineStatuses.omni.sidero.dev(default/test@1)",
|
|
},
|
|
{
|
|
message: "resource created",
|
|
resource: "ConfigPatches.omni.sidero.dev(default/test@1)",
|
|
},
|
|
{
|
|
message: "resource updated",
|
|
resource: "ClusterBootstrapStatuses.omni.sidero.dev(default/test@2)",
|
|
diff: `--- ClusterBootstrapStatuses.omni.sidero.dev(default/test)
|
|
+++ ClusterBootstrapStatuses.omni.sidero.dev(default/test)
|
|
@@ -2,10 +2,10 @@
|
|
namespace: default
|
|
type: ClusterBootstrapStatuses.omni.sidero.dev
|
|
id: test
|
|
- version: 1
|
|
+ version: 2
|
|
owner:
|
|
phase: running
|
|
created: 2000-01-01T00:00:00Z
|
|
- updated: 2000-01-01T00:00:00Z
|
|
+ updated: 2000-01-01T00:00:01Z
|
|
spec:
|
|
- bootstrapped: false
|
|
+ bootstrapped: true
|
|
`,
|
|
},
|
|
{
|
|
message: "resource updated",
|
|
resource: "MachineStatuses.omni.sidero.dev(default/test@2)",
|
|
diff: `--- MachineStatuses.omni.sidero.dev(default/test)
|
|
+++ MachineStatuses.omni.sidero.dev(default/test)
|
|
@@ -2,17 +2,17 @@
|
|
namespace: default
|
|
type: MachineStatuses.omni.sidero.dev
|
|
id: test
|
|
- version: 1
|
|
+ version: 2
|
|
owner:
|
|
phase: running
|
|
created: 2000-01-01T00:00:00Z
|
|
- updated: 2000-01-01T00:00:00Z
|
|
+ updated: 2000-01-01T00:00:01Z
|
|
spec:
|
|
talosversion: v1.2.3
|
|
hardware: null
|
|
network:
|
|
hostname: aaa
|
|
- domainname: bbb
|
|
+ domainname: ccc
|
|
addresses:
|
|
- 1.2.3.4
|
|
- 5.6.7.8
|
|
@@ -25,10 +17,10 @@
|
|
linkup: true
|
|
description: hello
|
|
lasterror: ""
|
|
- managementaddress: some-address
|
|
+ managementaddress: some-address-updated
|
|
connected: false
|
|
maintenance: false
|
|
- cluster: some-cluster
|
|
+ cluster: some-cluster-updated
|
|
role: 2
|
|
platformmetadata: null
|
|
imagelabels: {}
|
|
`,
|
|
},
|
|
{
|
|
message: "resource updated",
|
|
resource: "ConfigPatches.omni.sidero.dev(default/test@2)",
|
|
// there should be no diff logged, as ConfigPatches are sensitive resources
|
|
},
|
|
{
|
|
message: "resource destroyed",
|
|
resource: "MachineStatuses.omni.sidero.dev(default/test@2)",
|
|
},
|
|
{
|
|
message: "resource destroyed",
|
|
resource: "ClusterBootstrapStatuses.omni.sidero.dev(default/test@2)",
|
|
},
|
|
{
|
|
message: "resource destroyed",
|
|
resource: "ConfigPatches.omni.sidero.dev(default/test@2)",
|
|
},
|
|
})
|
|
})
|
|
}
|
|
|
|
type logEntry struct {
|
|
message string
|
|
resource string
|
|
diff string
|
|
}
|
|
|
|
func parseLogEntry(t *testing.T, entry observer.LoggedEntry) logEntry {
|
|
require.NotEmpty(t, entry.Context)
|
|
require.LessOrEqual(t, len(entry.Context), 2, "expected at most 2 context fields")
|
|
require.Equal(t, "resource", entry.Context[0].Key)
|
|
|
|
var diffLines []string
|
|
|
|
if len(entry.Context) == 2 {
|
|
require.Equal(t, "diff", entry.Context[1].Key)
|
|
|
|
data := entry.Context[1].Interface
|
|
|
|
// use reflection to convert private type zap.stringArray to []string
|
|
|
|
require.Equal(t, reflect.Slice, reflect.TypeOf(data).Kind())
|
|
require.Equal(t, reflect.String, reflect.TypeOf(data).Elem().Kind())
|
|
|
|
val := reflect.ValueOf(data)
|
|
|
|
diffLines = make([]string, 0, val.Len())
|
|
|
|
for i := range val.Len() {
|
|
diffLines = append(diffLines, val.Index(i).String())
|
|
}
|
|
}
|
|
|
|
return logEntry{
|
|
message: entry.Message,
|
|
resource: entry.Context[0].String,
|
|
diff: strings.Join(diffLines, "\n"),
|
|
}
|
|
}
|