mirrors/netboot
1
0
Fork 0
mirror of https://github.com/danderson/netboot.git synced 2025-10-17 10:31:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

dhcp4: fix portable Conn initialization and packet transmission.

Browse Source 
Conn is supposed to accept "" to mean "listen for DHCP on all interfaces",
but portableConn didn't correctly handle that.

And I got the comparison wrong on ifidx in the portable send function, so
packets got sent out entirely the wrong interface :(.
This commit is contained in:
David Anderson 2016-07-16 22:22:42 -07:00
parent 684f93040b
commit c9ec51e475
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dhcp4/conn.go
View File

@ -167,6 +167,9 @@ type portableConn struct {
}
func newPortableConn(addr string) (conn, error) {
if addr == "" {
addr = ":67"
}
c, err := net.ListenPacket("udp4", addr)
if err != nil {
return nil, err
@ -192,7 +195,7 @@ func (c *portableConn) Recv(b []byte) (rb []byte, addr *net.UDPAddr, ifidx int,
}
func (c *portableConn) Send(b []byte, addr *net.UDPAddr, ifidx int) error {
if ifidx > 0 {
if ifidx <= 0 {
_, err := c.conn.WriteTo(b, nil, addr)
return err
}