From b8b3aeb641f62e5ce4ca0a0ff05f1298f24610d6 Mon Sep 17 00:00:00 2001 From: pancho horrillo Date: Fri, 16 Jun 2017 07:59:39 +0200 Subject: [PATCH] Replace ENV with ARG at Dockerfile for vars that should not be persisted MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Vars declared via the ENV mechanism will also be present at run time, polluting somewhat the environment. Since both PIXIECORE_{SANDBOX,CONTEXT} are only needed at build time, using the ARG form is a cleaner solution. See ¹ for reference. ¹: https://docs.docker.com/engine/reference/builder/#arg --- dockerfiles/pixiecore/Dockerfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dockerfiles/pixiecore/Dockerfile b/dockerfiles/pixiecore/Dockerfile index 3006b54..1de9d58 100644 --- a/dockerfiles/pixiecore/Dockerfile +++ b/dockerfiles/pixiecore/Dockerfile @@ -2,8 +2,8 @@ FROM alpine:3.6 MAINTAINER David Anderson -ENV PIXIECORE_SANDBOX /tmp/sandbox -ENV PIXIECORE_CONTEXT "$PIXIECORE_SANDBOX"/context +ARG PIXIECORE_SANDBOX=/tmp/sandbox +ARG PIXIECORE_CONTEXT="$PIXIECORE_SANDBOX"/context COPY . "$PIXIECORE_CONTEXT"