mirrors/netboot
1
0
Fork 0
mirror of https://github.com/danderson/netboot.git synced 2025-08-07 07:07:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

dhcp4: allow duplication of option 56 (Debug message).

Browse Source 
Turns out real DHCP servers can duplicate this message.
This commit is contained in:
David Anderson 2016-06-18 16:44:06 -07:00
parent 7a39e0e685
commit 8dfa75434e
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dhcp4/options.go
View File

@ -93,7 +93,10 @@ func (o Options) Unmarshal(bs []byte) error {
// is going to be an error, until I get a bug report about
// something that actually does it.
if _, ok := o[opt]; ok {
return fmt.Errorf("packet has duplicate option %d (please file a bug with a pcap!)", opt)
// Okay fine option 56 can be duped.
if opt != 56 {
return fmt.Errorf("packet has duplicate option %d (please file a bug with a pcap!)", opt)
}
}
if len(bs) < 2 {
return fmt.Errorf("option %d has no length byte", opt)