mirrors/netboot
1
0
Fork 0
mirror of https://github.com/danderson/netboot.git synced 2025-10-16 01:51:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

pixiecore: factor the ipxe script generation out of the HTTP handler.

Browse Source 
This makes it easier to test the script generation in isolation,
as well as making the whole thing easier to follow.
This commit is contained in:
David Anderson 2016-08-10 21:54:16 -07:00
parent 6766b5ca59
commit 6a88cefc9b
1 changed files with 28 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
pixiecore/http.go
View File

@ -16,6 +16,7 @@ package pixiecore
import (
"bytes"
"errors"
"fmt"
"io"
"net"
@ -68,17 +69,36 @@ func (s *Server) handleIpxe(w http.ResponseWriter, r *http.Request) {
s.httpError(w, r, http.StatusNotFound, "no bootspec found for %q", mach.MAC)
return
}
if spec.Kernel == "" {
// TODO: maybe don't send this error over the network?
s.logHTTP(r, "invalid bootspec for %q: missing kernel", mach.MAC)
script, err := ipxeScript(spec, r.Host)
if err != nil {
s.logHTTP(r, "failed to assemble ipxe script: %s", err)
http.Error(w, "couldn't get a bootspec", http.StatusInternalServerError)
return
}
// All is well, assemble the iPXE script.
w.Header().Set("Content-Type", "text/plain")
w.Write(script)
}
urlPrefix := fmt.Sprintf("http://%s/_/file?name=", r.Host)
func (s *Server) handleFile(w http.ResponseWriter, r *http.Request) {
name := r.URL.Query().Get("name")
f, err := s.Booter.ReadBootFile(ID(name))
if err != nil {
s.logHTTP(r, "error getting requested file %q: %s", name, err)
http.Error(w, "couldn't get file", http.StatusInternalServerError)
return
}
defer f.Close()
if _, err = io.Copy(w, f); err != nil {
s.logHTTP(r, "copy of file %q failed: %s", name, err)
}
}
func ipxeScript(spec *Spec, serverHost string) ([]byte, error) {
if spec.Kernel == "" {
return nil, errors.New("spec is missing Kernel")
}
urlPrefix := fmt.Sprintf("http://%s/_/file?name=", serverHost)
var b bytes.Buffer
b.WriteString("#!ipxe\n")
fmt.Fprintf(&b, "kernel --name kernel %s%s\n", urlPrefix, url.QueryEscape(string(spec.Kernel)))
@ -98,26 +118,9 @@ func (s *Server) handleIpxe(w http.ResponseWriter, r *http.Request) {
case ID:
fmt.Fprintf(&b, "%s=%s%s ", k, urlPrefix, url.QueryEscape(string(val)))
default:
s.logHTTP(r, "invalid bootspec for %q: unknown cmdline type for key %q", mach.MAC, k)
http.Error(w, "couldn't get a bootspec", http.StatusInternalServerError)
return
return nil, fmt.Errorf("unsupported cmdline type %T for key %q", v, k)
}
}
b.WriteByte('\n')
w.Header().Set("Content-Type", "text/plain")
b.WriteTo(w)
}
func (s *Server) handleFile(w http.ResponseWriter, r *http.Request) {
name := r.URL.Query().Get("name")
f, err := s.Booter.ReadBootFile(ID(name))
if err != nil {
s.logHTTP(r, "error getting requested file %q: %s", name, err)
http.Error(w, "couldn't get file", http.StatusInternalServerError)
return
}
defer f.Close()
if _, err = io.Copy(w, f); err != nil {
s.logHTTP(r, "copy of file %q failed: %s", name, err)
}
return b.Bytes(), nil
}