mirror of
				https://github.com/minio/minio.git
				synced 2025-11-03 17:51:11 +01:00 
			
		
		
		
	- Adds an interface to update in-memory bucket metadata state called
  BucketMetaState - this interface has functions to:
     - update bucket notification configuration,
     - bucket listener configuration,
     - bucket policy configuration, and
     - send bucket event
- This interface is implemented by `localBMS` a type for manipulating
  local node in-memory bucket metadata, and by `remoteBMS` a type for
  manipulating remote node in-memory bucket metadata.
- The remote node interface, makes an RPC call, but the local node
  interface does not - it updates in-memory bucket state directly.
- Rename mkPeersFromEndpoints to makeS3Peers and refactored it.
- Use arrayslice instead of map in s3Peers struct
- `s3Peers.SendUpdate` now receives an arrayslice of peer indexes to
  send the request to, with a special nil value slice indicating that
  all peers should be sent the update.
- `s3Peers.SendUpdate` now returns an arrayslice of errors, representing
  errors from peers when sending an update. The array positions
  correspond to peer array s3Peers.peers
Improve globalS3Peers:
- Make isDistXL a global `globalIsDistXL` and remove from s3Peers
- Make globalS3Peers an array of (address, bucket-meta-state) pairs.
- Fix code and tests.
		
	
			
		
			
				
	
	
		
			64 lines
		
	
	
		
			1.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			64 lines
		
	
	
		
			1.7 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
/*
 | 
						|
 * Minio Cloud Storage, (C) 2016 Minio, Inc.
 | 
						|
 *
 | 
						|
 * Licensed under the Apache License, Version 2.0 (the "License");
 | 
						|
 * you may not use this file except in compliance with the License.
 | 
						|
 * You may obtain a copy of the License at
 | 
						|
 *
 | 
						|
 *     http://www.apache.org/licenses/LICENSE-2.0
 | 
						|
 *
 | 
						|
 * Unless required by applicable law or agreed to in writing, software
 | 
						|
 * distributed under the License is distributed on an "AS IS" BASIS,
 | 
						|
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | 
						|
 * See the License for the specific language governing permissions and
 | 
						|
 * limitations under the License.
 | 
						|
 */
 | 
						|
 | 
						|
package cmd
 | 
						|
 | 
						|
import (
 | 
						|
	"net/url"
 | 
						|
	"reflect"
 | 
						|
	"testing"
 | 
						|
)
 | 
						|
 | 
						|
// Validates makeS3Peers, fetches all peers based on list of storage
 | 
						|
// endpoints.
 | 
						|
func TestMakeS3Peers(t *testing.T) {
 | 
						|
	// Initialize configuration
 | 
						|
	root, err := newTestConfig("us-east-1")
 | 
						|
	if err != nil {
 | 
						|
		t.Fatalf("%s", err)
 | 
						|
	}
 | 
						|
	defer removeAll(root)
 | 
						|
 | 
						|
	// test cases
 | 
						|
	testCases := []struct {
 | 
						|
		gMinioAddr string
 | 
						|
		eps        []*url.URL
 | 
						|
		peers      []string
 | 
						|
	}{
 | 
						|
		{":9000", []*url.URL{{Path: "/mnt/disk1"}}, []string{":9000"}},
 | 
						|
		{":9000", []*url.URL{{Host: "localhost:9001"}}, []string{":9000", "localhost:9001"}},
 | 
						|
		{"m1:9000", []*url.URL{{Host: "m1:9000"}, {Host: "m2:9000"}, {Host: "m3:9000"}}, []string{"m1:9000", "m2:9000", "m3:9000"}},
 | 
						|
	}
 | 
						|
 | 
						|
	getPeersHelper := func(s3p s3Peers) []string {
 | 
						|
		r := []string{}
 | 
						|
		for _, p := range s3p {
 | 
						|
			r = append(r, p.addr)
 | 
						|
		}
 | 
						|
		return r
 | 
						|
	}
 | 
						|
 | 
						|
	// execute tests
 | 
						|
	for i, testCase := range testCases {
 | 
						|
		globalMinioAddr = testCase.gMinioAddr
 | 
						|
		s3peers := makeS3Peers(testCase.eps)
 | 
						|
		referencePeers := getPeersHelper(s3peers)
 | 
						|
		if !reflect.DeepEqual(testCase.peers, referencePeers) {
 | 
						|
			t.Errorf("Test %d: Expected %v, got %v", i+1, testCase.peers, referencePeers)
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 |