mirror of
				https://github.com/minio/minio.git
				synced 2025-10-31 00:01:27 +01:00 
			
		
		
		
	it would seem like using `bufio.Scan()` is very slow for heavy concurrent I/O, ie. when r.Body is slow , instead use a proper binary exchange format, to marshal and unmarshal the LockArgs datastructure in a cleaner way. this PR increases performance of the locking sub-system for tiny repeated read lock requests on same object. ``` BenchmarkLockArgs BenchmarkLockArgs-4 6417609 185.7 ns/op 56 B/op 2 allocs/op BenchmarkLockArgsOld BenchmarkLockArgsOld-4 1187368 1015 ns/op 4096 B/op 1 allocs/op ```
		
			
				
	
	
		
			45 lines
		
	
	
		
			1.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			45 lines
		
	
	
		
			1.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright (c) 2015-2021 MinIO, Inc.
 | |
| //
 | |
| // This file is part of MinIO Object Storage stack
 | |
| //
 | |
| // This program is free software: you can redistribute it and/or modify
 | |
| // it under the terms of the GNU Affero General Public License as published by
 | |
| // the Free Software Foundation, either version 3 of the License, or
 | |
| // (at your option) any later version.
 | |
| //
 | |
| // This program is distributed in the hope that it will be useful
 | |
| // but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | |
| // GNU Affero General Public License for more details.
 | |
| //
 | |
| // You should have received a copy of the GNU Affero General Public License
 | |
| // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 | |
| 
 | |
| package cmd
 | |
| 
 | |
| import (
 | |
| 	"errors"
 | |
| )
 | |
| 
 | |
| const (
 | |
| 	lockRESTVersion       = "v7" // Add msgp for lockArgs
 | |
| 	lockRESTVersionPrefix = SlashSeparator + lockRESTVersion
 | |
| 	lockRESTPrefix        = minioReservedBucketPath + "/lock"
 | |
| )
 | |
| 
 | |
| const (
 | |
| 	lockRESTMethodHealth      = "/health"
 | |
| 	lockRESTMethodRefresh     = "/refresh"
 | |
| 	lockRESTMethodLock        = "/lock"
 | |
| 	lockRESTMethodRLock       = "/rlock"
 | |
| 	lockRESTMethodUnlock      = "/unlock"
 | |
| 	lockRESTMethodRUnlock     = "/runlock"
 | |
| 	lockRESTMethodForceUnlock = "/force-unlock"
 | |
| )
 | |
| 
 | |
| var (
 | |
| 	errLockConflict       = errors.New("lock conflict")
 | |
| 	errLockNotInitialized = errors.New("lock not initialized")
 | |
| 	errLockNotFound       = errors.New("lock not found")
 | |
| )
 |