mirror of
				https://github.com/minio/minio.git
				synced 2025-11-04 10:11:09 +01:00 
			
		
		
		
	This refactor is done for few reasons below - to avoid deadlocks in scenarios when number of nodes are smaller < actual erasure stripe count where in N participating local lockers can lead to deadlocks across systems. - avoids expiry routines to run 1000 of separate network operations and routes per disk where as each of them are still accessing one single local entity. - it is ideal to have since globalLockServer per instance. - In a 32node deployment however, each server group is still concentrated towards the same set of lockers that partipicate during the write/read phase, unlike previous minio/dsync implementation - this potentially avoids send 32 requests instead we will still send at max requests of unique nodes participating in a write/read phase. - reduces overall chattiness on smaller setups.
		
			
				
	
	
		
			260 lines
		
	
	
		
			7.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			260 lines
		
	
	
		
			7.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
/*
 | 
						|
 * MinIO Cloud Storage, (C) 2018, 2019 MinIO, Inc.
 | 
						|
 *
 | 
						|
 * Licensed under the Apache License, Version 2.0 (the "License");
 | 
						|
 * you may not use this file except in compliance with the License.
 | 
						|
 * You may obtain a copy of the License at
 | 
						|
 *
 | 
						|
 *     http://www.apache.org/licenses/LICENSE-2.0
 | 
						|
 *
 | 
						|
 * Unless required by applicable law or agreed to in writing, software
 | 
						|
 * distributed under the License is distributed on an "AS IS" BASIS,
 | 
						|
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | 
						|
 * See the License for the specific language governing permissions and
 | 
						|
 * limitations under the License.
 | 
						|
 */
 | 
						|
 | 
						|
package cmd
 | 
						|
 | 
						|
import (
 | 
						|
	"context"
 | 
						|
	"fmt"
 | 
						|
	"sync"
 | 
						|
	"time"
 | 
						|
 | 
						|
	"github.com/minio/minio/pkg/dsync"
 | 
						|
)
 | 
						|
 | 
						|
// lockRequesterInfo stores various info from the client for each lock that is requested.
 | 
						|
type lockRequesterInfo struct {
 | 
						|
	Writer        bool      // Bool whether write or read lock.
 | 
						|
	UID           string    // UID to uniquely identify request of client.
 | 
						|
	Timestamp     time.Time // Timestamp set at the time of initialization.
 | 
						|
	TimeLastCheck time.Time // Timestamp for last check of validity of lock.
 | 
						|
	Source        string    // Contains line, function and filename reqesting the lock.
 | 
						|
	// Owner represents the UUID of the owner who originally requested the lock
 | 
						|
	// useful in expiry.
 | 
						|
	Owner string
 | 
						|
	// Quorum represents the quorum required for this lock to be active.
 | 
						|
	Quorum int
 | 
						|
}
 | 
						|
 | 
						|
// isWriteLock returns whether the lock is a write or read lock.
 | 
						|
func isWriteLock(lri []lockRequesterInfo) bool {
 | 
						|
	return len(lri) == 1 && lri[0].Writer
 | 
						|
}
 | 
						|
 | 
						|
// localLocker implements Dsync.NetLocker
 | 
						|
type localLocker struct {
 | 
						|
	mutex   sync.Mutex
 | 
						|
	lockMap map[string][]lockRequesterInfo
 | 
						|
}
 | 
						|
 | 
						|
func (l *localLocker) String() string {
 | 
						|
	return globalEndpoints.Localhost()
 | 
						|
}
 | 
						|
 | 
						|
func (l *localLocker) canTakeUnlock(resources ...string) bool {
 | 
						|
	var lkCnt int
 | 
						|
	for _, resource := range resources {
 | 
						|
		isWriteLockTaken := isWriteLock(l.lockMap[resource])
 | 
						|
		if isWriteLockTaken {
 | 
						|
			lkCnt++
 | 
						|
		}
 | 
						|
	}
 | 
						|
	return lkCnt == len(resources)
 | 
						|
}
 | 
						|
 | 
						|
func (l *localLocker) canTakeLock(resources ...string) bool {
 | 
						|
	var noLkCnt int
 | 
						|
	for _, resource := range resources {
 | 
						|
		_, lockTaken := l.lockMap[resource]
 | 
						|
		if !lockTaken {
 | 
						|
			noLkCnt++
 | 
						|
		}
 | 
						|
	}
 | 
						|
	return noLkCnt == len(resources)
 | 
						|
}
 | 
						|
 | 
						|
func (l *localLocker) Lock(ctx context.Context, args dsync.LockArgs) (reply bool, err error) {
 | 
						|
	l.mutex.Lock()
 | 
						|
	defer l.mutex.Unlock()
 | 
						|
 | 
						|
	if !l.canTakeLock(args.Resources...) {
 | 
						|
		// Not all locks can be taken on resources,
 | 
						|
		// reject it completely.
 | 
						|
		return false, nil
 | 
						|
	}
 | 
						|
 | 
						|
	// No locks held on the all resources, so claim write
 | 
						|
	// lock on all resources at once.
 | 
						|
	for _, resource := range args.Resources {
 | 
						|
		l.lockMap[resource] = []lockRequesterInfo{
 | 
						|
			{
 | 
						|
				Writer:        true,
 | 
						|
				Source:        args.Source,
 | 
						|
				Owner:         args.Owner,
 | 
						|
				UID:           args.UID,
 | 
						|
				Timestamp:     UTCNow(),
 | 
						|
				TimeLastCheck: UTCNow(),
 | 
						|
				Quorum:        args.Quorum,
 | 
						|
			},
 | 
						|
		}
 | 
						|
	}
 | 
						|
	return true, nil
 | 
						|
}
 | 
						|
 | 
						|
func (l *localLocker) Unlock(args dsync.LockArgs) (reply bool, err error) {
 | 
						|
	l.mutex.Lock()
 | 
						|
	defer l.mutex.Unlock()
 | 
						|
 | 
						|
	if !l.canTakeUnlock(args.Resources...) {
 | 
						|
		// Unless it is a write lock reject it.
 | 
						|
		return reply, fmt.Errorf("Unlock attempted on a read locked entity: %s", args.Resources)
 | 
						|
	}
 | 
						|
	for _, resource := range args.Resources {
 | 
						|
		lri, ok := l.lockMap[resource]
 | 
						|
		if ok {
 | 
						|
			l.removeEntry(resource, args, &lri)
 | 
						|
		}
 | 
						|
	}
 | 
						|
	return true, nil
 | 
						|
 | 
						|
}
 | 
						|
 | 
						|
// removeEntry based on the uid of the lock message, removes a single entry from the
 | 
						|
// lockRequesterInfo array or the whole array from the map (in case of a write lock
 | 
						|
// or last read lock)
 | 
						|
func (l *localLocker) removeEntry(name string, args dsync.LockArgs, lri *[]lockRequesterInfo) bool {
 | 
						|
	// Find correct entry to remove based on uid.
 | 
						|
	for index, entry := range *lri {
 | 
						|
		if entry.UID == args.UID && entry.Owner == args.Owner {
 | 
						|
			if len(*lri) == 1 {
 | 
						|
				// Remove the write lock.
 | 
						|
				delete(l.lockMap, name)
 | 
						|
			} else {
 | 
						|
				// Remove the appropriate read lock.
 | 
						|
				*lri = append((*lri)[:index], (*lri)[index+1:]...)
 | 
						|
				l.lockMap[name] = *lri
 | 
						|
			}
 | 
						|
			return true
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	// None found return false, perhaps entry removed in previous run.
 | 
						|
	return false
 | 
						|
}
 | 
						|
 | 
						|
func (l *localLocker) RLock(ctx context.Context, args dsync.LockArgs) (reply bool, err error) {
 | 
						|
	l.mutex.Lock()
 | 
						|
	defer l.mutex.Unlock()
 | 
						|
	lrInfo := lockRequesterInfo{
 | 
						|
		Writer:        false,
 | 
						|
		Source:        args.Source,
 | 
						|
		Owner:         args.Owner,
 | 
						|
		UID:           args.UID,
 | 
						|
		Timestamp:     UTCNow(),
 | 
						|
		TimeLastCheck: UTCNow(),
 | 
						|
		Quorum:        args.Quorum,
 | 
						|
	}
 | 
						|
	resource := args.Resources[0]
 | 
						|
	if lri, ok := l.lockMap[resource]; ok {
 | 
						|
		if reply = !isWriteLock(lri); reply {
 | 
						|
			// Unless there is a write lock
 | 
						|
			l.lockMap[resource] = append(l.lockMap[resource], lrInfo)
 | 
						|
		}
 | 
						|
	} else {
 | 
						|
		// No locks held on the given name, so claim (first) read lock
 | 
						|
		l.lockMap[resource] = []lockRequesterInfo{lrInfo}
 | 
						|
		reply = true
 | 
						|
	}
 | 
						|
	return reply, nil
 | 
						|
}
 | 
						|
 | 
						|
func (l *localLocker) RUnlock(args dsync.LockArgs) (reply bool, err error) {
 | 
						|
	l.mutex.Lock()
 | 
						|
	defer l.mutex.Unlock()
 | 
						|
	var lri []lockRequesterInfo
 | 
						|
 | 
						|
	resource := args.Resources[0]
 | 
						|
	if lri, reply = l.lockMap[resource]; !reply {
 | 
						|
		// No lock is held on the given name
 | 
						|
		return true, nil
 | 
						|
	}
 | 
						|
	if reply = !isWriteLock(lri); !reply {
 | 
						|
		// A write-lock is held, cannot release a read lock
 | 
						|
		return reply, fmt.Errorf("RUnlock attempted on a write locked entity: %s", resource)
 | 
						|
	}
 | 
						|
	l.removeEntry(resource, args, &lri)
 | 
						|
	return reply, nil
 | 
						|
}
 | 
						|
 | 
						|
func (l *localLocker) DupLockMap() map[string][]lockRequesterInfo {
 | 
						|
	l.mutex.Lock()
 | 
						|
	defer l.mutex.Unlock()
 | 
						|
 | 
						|
	lockCopy := map[string][]lockRequesterInfo{}
 | 
						|
	for k, v := range l.lockMap {
 | 
						|
		lockCopy[k] = append(lockCopy[k], v...)
 | 
						|
	}
 | 
						|
	return lockCopy
 | 
						|
}
 | 
						|
 | 
						|
func (l *localLocker) Close() error {
 | 
						|
	return nil
 | 
						|
}
 | 
						|
 | 
						|
// IsOnline - local locker is always online.
 | 
						|
func (l *localLocker) IsOnline() bool {
 | 
						|
	return true
 | 
						|
}
 | 
						|
 | 
						|
// IsLocal - local locker returns true.
 | 
						|
func (l *localLocker) IsLocal() bool {
 | 
						|
	return true
 | 
						|
}
 | 
						|
 | 
						|
func (l *localLocker) Expired(ctx context.Context, args dsync.LockArgs) (expired bool, err error) {
 | 
						|
	select {
 | 
						|
	case <-ctx.Done():
 | 
						|
		return false, ctx.Err()
 | 
						|
	default:
 | 
						|
		l.mutex.Lock()
 | 
						|
		defer l.mutex.Unlock()
 | 
						|
 | 
						|
		// Lock found, proceed to verify if belongs to given uid.
 | 
						|
		for _, resource := range args.Resources {
 | 
						|
			if lri, ok := l.lockMap[resource]; ok {
 | 
						|
				// Check whether uid is still active
 | 
						|
				for _, entry := range lri {
 | 
						|
					if entry.UID == args.UID && entry.Owner == args.Owner {
 | 
						|
						return false, nil
 | 
						|
					}
 | 
						|
				}
 | 
						|
			}
 | 
						|
		}
 | 
						|
		return true, nil
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
// Similar to removeEntry but only removes an entry only if the lock entry exists in map.
 | 
						|
// Caller must hold 'l.mutex' lock.
 | 
						|
func (l *localLocker) removeEntryIfExists(nlrip nameLockRequesterInfoPair) {
 | 
						|
	l.mutex.Lock()
 | 
						|
	defer l.mutex.Unlock()
 | 
						|
 | 
						|
	// Check if entry is still in map (could have been removed altogether by 'concurrent' (R)Unlock of last entry)
 | 
						|
	if lri, ok := l.lockMap[nlrip.name]; ok {
 | 
						|
		// Even if the entry exists, it may not be the same entry which was
 | 
						|
		// considered as expired, so we simply an attempt to remove it if its
 | 
						|
		// not possible there is nothing we need to do.
 | 
						|
		l.removeEntry(nlrip.name, dsync.LockArgs{Owner: nlrip.lri.Owner, UID: nlrip.lri.UID}, &lri)
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func newLocker() *localLocker {
 | 
						|
	return &localLocker{
 | 
						|
		lockMap: make(map[string][]lockRequesterInfo),
 | 
						|
	}
 | 
						|
}
 |