mirror of
https://github.com/minio/minio.git
synced 2025-11-04 10:11:09 +01:00
0a3b1ad4eb
This commit replaces `ioutil.TempDir` with `t.TempDir` in tests. The
directory created by `t.TempDir` is automatically removed when the test
and all its subtests complete.
Prior to this commit, temporary directory created using `ioutil.TempDir`
needs to be removed manually by calling `os.RemoveAll`, which is omitted
in some tests. The error handling boilerplate e.g.
defer func() {
if err := os.RemoveAll(dir); err != nil {
t.Fatal(err)
}
}
is also tedious, but `t.TempDir` handles this for us nicely.
Reference: https://pkg.go.dev/testing#T.TempDir
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
112 lines
3.2 KiB
Go
112 lines
3.2 KiB
Go
// Copyright (c) 2015-2021 MinIO, Inc.
|
|
//
|
|
// This file is part of MinIO Object Storage stack
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package cmd
|
|
|
|
import (
|
|
"runtime"
|
|
"testing"
|
|
|
|
"github.com/minio/minio/internal/lock"
|
|
)
|
|
|
|
// Tests long path calls.
|
|
func TestRWPoolLongPath(t *testing.T) {
|
|
rwPool := &fsIOPool{
|
|
readersMap: make(map[string]*lock.RLockedFile),
|
|
}
|
|
|
|
longPath := "my-obj-del-0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001"
|
|
if _, err := rwPool.Create(longPath); err != errFileNameTooLong {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if _, err := rwPool.Write(longPath); err != errFileNameTooLong {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if _, err := rwPool.Open(longPath); err != errFileNameTooLong {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
// Tests all RWPool methods.
|
|
func TestRWPool(t *testing.T) {
|
|
// create xlStorage test setup
|
|
_, path, err := newXLStorageTestSetup(t)
|
|
if err != nil {
|
|
t.Fatalf("Unable to create xlStorage test setup, %s", err)
|
|
}
|
|
|
|
rwPool := &fsIOPool{
|
|
readersMap: make(map[string]*lock.RLockedFile),
|
|
}
|
|
wlk, err := rwPool.Create(pathJoin(path, "success-vol", "file/path/1.txt"))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
wlk.Close()
|
|
|
|
// Fails to create a parent directory if there is a file.
|
|
_, err = rwPool.Create(pathJoin(path, "success-vol", "file/path/1.txt/test"))
|
|
if err != errFileAccessDenied {
|
|
t.Fatal("Unexpected error", err)
|
|
}
|
|
|
|
// Fails to create a file if there is a directory.
|
|
_, err = rwPool.Create(pathJoin(path, "success-vol", "file"))
|
|
if runtime.GOOS == globalWindowsOSName {
|
|
if err != errFileAccessDenied {
|
|
t.Fatal("Unexpected error", err)
|
|
}
|
|
} else {
|
|
if err != errIsNotRegular {
|
|
t.Fatal("Unexpected error", err)
|
|
}
|
|
}
|
|
|
|
rlk, err := rwPool.Open(pathJoin(path, "success-vol", "file/path/1.txt"))
|
|
if err != nil {
|
|
t.Fatal("Unexpected error", err)
|
|
}
|
|
rlk.Close()
|
|
|
|
// Fails to read a directory.
|
|
_, err = rwPool.Open(pathJoin(path, "success-vol", "file"))
|
|
if runtime.GOOS == globalWindowsOSName {
|
|
if err != errFileAccessDenied {
|
|
t.Fatal("Unexpected error", err)
|
|
}
|
|
} else {
|
|
if err != errIsNotRegular {
|
|
t.Fatal("Unexpected error", err)
|
|
}
|
|
}
|
|
|
|
// Fails to open a file which has a parent as file.
|
|
_, err = rwPool.Open(pathJoin(path, "success-vol", "file/path/1.txt/test"))
|
|
if runtime.GOOS != globalWindowsOSName {
|
|
if err != errFileAccessDenied {
|
|
t.Fatal("Unexpected error", err)
|
|
}
|
|
} else {
|
|
if err != errFileNotFound {
|
|
t.Fatal("Unexpected error", err)
|
|
}
|
|
}
|
|
}
|