mirror of
				https://github.com/minio/minio.git
				synced 2025-11-04 02:01:05 +01:00 
			
		
		
		
	This PR makes a feasible approach to handle all the scenarios that we must face to avoid returning "panic." Instead, we must return "errServerNotInitialized" when a bucketMetadataSys.Get() is called, allowing the caller to retry their operation and wait. Bonus fix the way data-usage-cache stores the object. Instead of storing usage-cache.bin with the bucket as `.minio.sys/buckets`, the `buckets` must be relative to the bucket `.minio.sys` as part of the object name. Otherwise, there is no way to decommission entries at `.minio.sys/buckets` and their final erasure set positions. A bucket must never have a `/` in it. Adds code to read() from existing data-usage.bin upon upgrade.
		
			
				
	
	
		
			194 lines
		
	
	
		
			5.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			194 lines
		
	
	
		
			5.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright (c) 2015-2021 MinIO, Inc.
 | 
						|
//
 | 
						|
// This file is part of MinIO Object Storage stack
 | 
						|
//
 | 
						|
// This program is free software: you can redistribute it and/or modify
 | 
						|
// it under the terms of the GNU Affero General Public License as published by
 | 
						|
// the Free Software Foundation, either version 3 of the License, or
 | 
						|
// (at your option) any later version.
 | 
						|
//
 | 
						|
// This program is distributed in the hope that it will be useful
 | 
						|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
 | 
						|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | 
						|
// GNU Affero General Public License for more details.
 | 
						|
//
 | 
						|
// You should have received a copy of the GNU Affero General Public License
 | 
						|
// along with this program.  If not, see <http://www.gnu.org/licenses/>.
 | 
						|
 | 
						|
package cmd
 | 
						|
 | 
						|
import (
 | 
						|
	"fmt"
 | 
						|
	"os"
 | 
						|
	"path"
 | 
						|
)
 | 
						|
 | 
						|
// Wrapper functions to os.RemoveAll, which calls reliableRemoveAll
 | 
						|
// this is to ensure that if there is a racy parent directory
 | 
						|
// create in between we can simply retry the operation.
 | 
						|
func removeAll(dirPath string) (err error) {
 | 
						|
	if dirPath == "" {
 | 
						|
		return errInvalidArgument
 | 
						|
	}
 | 
						|
 | 
						|
	if err = checkPathLength(dirPath); err != nil {
 | 
						|
		return err
 | 
						|
	}
 | 
						|
 | 
						|
	if err = reliableRemoveAll(dirPath); err != nil {
 | 
						|
		switch {
 | 
						|
		case isSysErrNotDir(err):
 | 
						|
			// File path cannot be verified since one of
 | 
						|
			// the parents is a file.
 | 
						|
			return errFileAccessDenied
 | 
						|
		case isSysErrPathNotFound(err):
 | 
						|
			// This is a special case should be handled only for
 | 
						|
			// windows, because windows API does not return "not a
 | 
						|
			// directory" error message. Handle this specifically
 | 
						|
			// here.
 | 
						|
			return errFileAccessDenied
 | 
						|
		}
 | 
						|
	}
 | 
						|
	return err
 | 
						|
}
 | 
						|
 | 
						|
// Reliably retries os.RemoveAll if for some reason os.RemoveAll returns
 | 
						|
// syscall.ENOTEMPTY (children has files).
 | 
						|
func reliableRemoveAll(dirPath string) (err error) {
 | 
						|
	i := 0
 | 
						|
	for {
 | 
						|
		// Removes all the directories and files.
 | 
						|
		if err = RemoveAll(dirPath); err != nil {
 | 
						|
			// Retry only for the first retryable error.
 | 
						|
			if isSysErrNotEmpty(err) && i == 0 {
 | 
						|
				i++
 | 
						|
				continue
 | 
						|
			}
 | 
						|
		}
 | 
						|
		break
 | 
						|
	}
 | 
						|
	return err
 | 
						|
}
 | 
						|
 | 
						|
// Wrapper functions to os.MkdirAll, which calls reliableMkdirAll
 | 
						|
// this is to ensure that if there is a racy parent directory
 | 
						|
// delete in between we can simply retry the operation.
 | 
						|
func mkdirAll(dirPath string, mode os.FileMode, baseDir string) (err error) {
 | 
						|
	if dirPath == "" {
 | 
						|
		return errInvalidArgument
 | 
						|
	}
 | 
						|
 | 
						|
	if err = checkPathLength(dirPath); err != nil {
 | 
						|
		return err
 | 
						|
	}
 | 
						|
 | 
						|
	if err = reliableMkdirAll(dirPath, mode, baseDir); err != nil {
 | 
						|
		// File path cannot be verified since one of the parents is a file.
 | 
						|
		if isSysErrNotDir(err) {
 | 
						|
			return errFileAccessDenied
 | 
						|
		} else if isSysErrPathNotFound(err) {
 | 
						|
			// This is a special case should be handled only for
 | 
						|
			// windows, because windows API does not return "not a
 | 
						|
			// directory" error message. Handle this specifically here.
 | 
						|
			return errFileAccessDenied
 | 
						|
		}
 | 
						|
		return osErrToFileErr(err)
 | 
						|
	}
 | 
						|
 | 
						|
	return nil
 | 
						|
}
 | 
						|
 | 
						|
// Reliably retries os.MkdirAll if for some reason os.MkdirAll returns
 | 
						|
// syscall.ENOENT (parent does not exist).
 | 
						|
func reliableMkdirAll(dirPath string, mode os.FileMode, baseDir string) (err error) {
 | 
						|
	i := 0
 | 
						|
	for {
 | 
						|
		// Creates all the parent directories, with mode 0777 mkdir honors system umask.
 | 
						|
		if err = osMkdirAll(dirPath, mode, baseDir); err != nil {
 | 
						|
			// Retry only for the first retryable error.
 | 
						|
			if osIsNotExist(err) && i == 0 {
 | 
						|
				i++
 | 
						|
				// Determine if os.NotExist error is because of
 | 
						|
				// baseDir's parent being present, retry it once such
 | 
						|
				// that the MkdirAll is retried once for the parent
 | 
						|
				// of dirPath.
 | 
						|
				// Because it is worth a retry to skip a different
 | 
						|
				// baseDir which is slightly higher up the depth.
 | 
						|
				nbaseDir := path.Dir(baseDir)
 | 
						|
				if baseDir != "" && nbaseDir != "" && nbaseDir != SlashSeparator {
 | 
						|
					baseDir = nbaseDir
 | 
						|
				}
 | 
						|
				continue
 | 
						|
			}
 | 
						|
		}
 | 
						|
		break
 | 
						|
	}
 | 
						|
	return err
 | 
						|
}
 | 
						|
 | 
						|
// Wrapper function to os.Rename, which calls reliableMkdirAll
 | 
						|
// and reliableRenameAll. This is to ensure that if there is a
 | 
						|
// racy parent directory delete in between we can simply retry
 | 
						|
// the operation.
 | 
						|
func renameAll(srcFilePath, dstFilePath, baseDir string) (err error) {
 | 
						|
	if srcFilePath == "" || dstFilePath == "" {
 | 
						|
		return errInvalidArgument
 | 
						|
	}
 | 
						|
 | 
						|
	if err = checkPathLength(srcFilePath); err != nil {
 | 
						|
		return err
 | 
						|
	}
 | 
						|
	if err = checkPathLength(dstFilePath); err != nil {
 | 
						|
		return err
 | 
						|
	}
 | 
						|
 | 
						|
	if err = reliableRename(srcFilePath, dstFilePath, baseDir); err != nil {
 | 
						|
		switch {
 | 
						|
		case isSysErrNotDir(err) && !osIsNotExist(err):
 | 
						|
			// Windows can have both isSysErrNotDir(err) and osIsNotExist(err) returning
 | 
						|
			// true if the source file path contains an non-existent directory. In that case,
 | 
						|
			// we want to return errFileNotFound instead, which will honored in subsequent
 | 
						|
			// switch cases
 | 
						|
			return errFileAccessDenied
 | 
						|
		case isSysErrPathNotFound(err):
 | 
						|
			// This is a special case should be handled only for
 | 
						|
			// windows, because windows API does not return "not a
 | 
						|
			// directory" error message. Handle this specifically here.
 | 
						|
			return errFileAccessDenied
 | 
						|
		case isSysErrCrossDevice(err):
 | 
						|
			return fmt.Errorf("%w (%s)->(%s)", errCrossDeviceLink, srcFilePath, dstFilePath)
 | 
						|
		case osIsNotExist(err):
 | 
						|
			return errFileNotFound
 | 
						|
		case osIsExist(err):
 | 
						|
			// This is returned only when destination is a directory and we
 | 
						|
			// are attempting a rename from file to directory.
 | 
						|
			return errIsNotRegular
 | 
						|
		default:
 | 
						|
			return err
 | 
						|
		}
 | 
						|
	}
 | 
						|
	return nil
 | 
						|
}
 | 
						|
 | 
						|
// Reliably retries os.RenameAll if for some reason os.RenameAll returns
 | 
						|
// syscall.ENOENT (parent does not exist).
 | 
						|
func reliableRename(srcFilePath, dstFilePath, baseDir string) (err error) {
 | 
						|
	if err = reliableMkdirAll(path.Dir(dstFilePath), 0o777, baseDir); err != nil {
 | 
						|
		return err
 | 
						|
	}
 | 
						|
 | 
						|
	i := 0
 | 
						|
	for {
 | 
						|
		// After a successful parent directory create attempt a renameAll.
 | 
						|
		if err = Rename(srcFilePath, dstFilePath); err != nil {
 | 
						|
			// Retry only for the first retryable error.
 | 
						|
			if osIsNotExist(err) && i == 0 {
 | 
						|
				i++
 | 
						|
				continue
 | 
						|
			}
 | 
						|
		}
 | 
						|
		break
 | 
						|
	}
 | 
						|
	return err
 | 
						|
}
 |