mirror of
				https://github.com/minio/minio.git
				synced 2025-10-31 08:11:19 +01:00 
			
		
		
		
	`decryptObjectInfo` is a significant bottleneck when listing objects. Reduce the allocations for a significant speedup. https://github.com/minio/sio/pull/40 ``` λ benchcmp before.txt after.txt benchmark old ns/op new ns/op delta Benchmark_decryptObjectInfo-32 24260928 808656 -96.67% benchmark old MB/s new MB/s speedup Benchmark_decryptObjectInfo-32 0.04 1.24 31.00x benchmark old allocs new allocs delta Benchmark_decryptObjectInfo-32 75112 48996 -34.77% benchmark old bytes new bytes delta Benchmark_decryptObjectInfo-32 287694772 4228076 -98.53% ```
		
			
				
	
	
		
			116 lines
		
	
	
		
			5.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			116 lines
		
	
	
		
			5.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // MinIO Cloud Storage, (C) 2015, 2016, 2017, 2018 MinIO, Inc.
 | |
| //
 | |
| // Licensed under the Apache License, Version 2.0 (the "License");
 | |
| // you may not use this file except in compliance with the License.
 | |
| // You may obtain a copy of the License at
 | |
| //
 | |
| //    http://www.apache.org/licenses/LICENSE-2.0
 | |
| //
 | |
| // Unless required by applicable law or agreed to in writing, software
 | |
| // distributed under the License is distributed on an "AS IS" BASIS,
 | |
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | |
| // See the License for the specific language governing permissions and
 | |
| // limitations under the License.
 | |
| 
 | |
| package crypto
 | |
| 
 | |
| import (
 | |
| 	"bytes"
 | |
| 	"fmt"
 | |
| 	"path"
 | |
| 	"strings"
 | |
| 	"testing"
 | |
| )
 | |
| 
 | |
| var masterKeyKMSTests = []struct {
 | |
| 	GenKeyID, UnsealKeyID     string
 | |
| 	GenContext, UnsealContext Context
 | |
| 
 | |
| 	ShouldFail bool
 | |
| }{
 | |
| 	{GenKeyID: "", UnsealKeyID: "", GenContext: Context{}, UnsealContext: nil, ShouldFail: false},                                                                                     // 0
 | |
| 	{GenKeyID: "ac47be7f", UnsealKeyID: "ac47be7f", GenContext: Context{}, UnsealContext: Context{}, ShouldFail: false},                                                               // 1
 | |
| 	{GenKeyID: "ac47be7f", UnsealKeyID: "ac47be7f", GenContext: Context{"bucket": "object"}, UnsealContext: Context{"bucket": "object"}, ShouldFail: false},                           // 2
 | |
| 	{GenKeyID: "", UnsealKeyID: "", GenContext: Context{"bucket": path.Join("bucket", "object")}, UnsealContext: Context{"bucket": path.Join("bucket", "object")}, ShouldFail: false}, // 3
 | |
| 	{GenKeyID: "", UnsealKeyID: "", GenContext: Context{"a": "a", "0": "0", "b": "b"}, UnsealContext: Context{"b": "b", "a": "a", "0": "0"}, ShouldFail: false},                       // 4
 | |
| 
 | |
| 	{GenKeyID: "ac47be7f", UnsealKeyID: "ac47be7e", GenContext: Context{}, UnsealContext: Context{}, ShouldFail: true},                                                               // 5
 | |
| 	{GenKeyID: "ac47be7f", UnsealKeyID: "ac47be7f", GenContext: Context{"bucket": "object"}, UnsealContext: Context{"Bucket": "object"}, ShouldFail: true},                           // 6
 | |
| 	{GenKeyID: "", UnsealKeyID: "", GenContext: Context{"bucket": path.Join("bucket", "Object")}, UnsealContext: Context{"bucket": path.Join("bucket", "object")}, ShouldFail: true}, // 7
 | |
| 	{GenKeyID: "", UnsealKeyID: "", GenContext: Context{"a": "a", "0": "1", "b": "b"}, UnsealContext: Context{"b": "b", "a": "a", "0": "0"}, ShouldFail: true},                       // 8
 | |
| }
 | |
| 
 | |
| func TestMasterKeyKMS(t *testing.T) {
 | |
| 	for i, test := range masterKeyKMSTests {
 | |
| 		kms := NewMasterKey(test.GenKeyID, [32]byte{})
 | |
| 
 | |
| 		key, sealedKey, err := kms.GenerateKey(test.GenKeyID, test.GenContext)
 | |
| 		if err != nil {
 | |
| 			t.Errorf("Test %d: KMS failed to generate key: %v", i, err)
 | |
| 		}
 | |
| 		unsealedKey, err := kms.UnsealKey(test.UnsealKeyID, sealedKey, test.UnsealContext)
 | |
| 		if err != nil && !test.ShouldFail {
 | |
| 			t.Errorf("Test %d: KMS failed to unseal the generated key: %v", i, err)
 | |
| 		}
 | |
| 		if err == nil && test.ShouldFail {
 | |
| 			t.Errorf("Test %d: KMS unsealed the generated key successfully but should have failed", i)
 | |
| 		}
 | |
| 		if !test.ShouldFail && !bytes.Equal(key[:], unsealedKey[:]) {
 | |
| 			t.Errorf("Test %d: The generated and unsealed key differ", i)
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| var contextWriteToTests = []struct {
 | |
| 	Context      Context
 | |
| 	ExpectedJSON string
 | |
| }{
 | |
| 	{Context: Context{}, ExpectedJSON: "{}"},                                                    // 0
 | |
| 	{Context: Context{"a": "b"}, ExpectedJSON: `{"a":"b"}`},                                     // 1
 | |
| 	{Context: Context{"a": "b", "c": "d"}, ExpectedJSON: `{"a":"b","c":"d"}`},                   // 2
 | |
| 	{Context: Context{"c": "d", "a": "b"}, ExpectedJSON: `{"a":"b","c":"d"}`},                   // 3
 | |
| 	{Context: Context{"0": "1", "-": "2", ".": "#"}, ExpectedJSON: `{"-":"2",".":"#","0":"1"}`}, // 4
 | |
| }
 | |
| 
 | |
| func TestContextWriteTo(t *testing.T) {
 | |
| 	for i, test := range contextWriteToTests {
 | |
| 		var jsonContext strings.Builder
 | |
| 		if _, err := test.Context.WriteTo(&jsonContext); err != nil {
 | |
| 			t.Errorf("Test %d: Failed to encode context: %v", i, err)
 | |
| 			continue
 | |
| 		}
 | |
| 		if s := jsonContext.String(); s != test.ExpectedJSON {
 | |
| 			t.Errorf("Test %d: JSON representation differ - got: '%s' want: '%s'", i, s, test.ExpectedJSON)
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestContextAppendTo(t *testing.T) {
 | |
| 	for i, test := range contextWriteToTests {
 | |
| 		dst := make([]byte, 0, 1024)
 | |
| 		dst = test.Context.AppendTo(dst)
 | |
| 		if s := string(dst); s != test.ExpectedJSON {
 | |
| 			t.Errorf("Test %d: JSON representation differ - got: '%s' want: '%s'", i, s, test.ExpectedJSON)
 | |
| 		}
 | |
| 		// Append one more
 | |
| 		dst = test.Context.AppendTo(dst)
 | |
| 		if s := string(dst); s != test.ExpectedJSON+test.ExpectedJSON {
 | |
| 			t.Errorf("Test %d: JSON representation differ - got: '%s' want: '%s'", i, s, test.ExpectedJSON+test.ExpectedJSON)
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func BenchmarkContext_AppendTo(b *testing.B) {
 | |
| 	tests := []Context{{}, {"bucket": "warp-benchmark-bucket"}, {"0": "1", "-": "2", ".": "#"}, {"34trg": "dfioutr89", "ikjfdghkjf": "jkedfhgfjkhg", "sdfhsdjkh": "if88889", "asddsirfh804": "kjfdshgdfuhgfg78-45604586#$%"}}
 | |
| 	for _, test := range tests {
 | |
| 		b.Run(fmt.Sprintf("%d-elems", len(test)), func(b *testing.B) {
 | |
| 			dst := make([]byte, 0, 1024)
 | |
| 			b.ReportAllocs()
 | |
| 			b.ResetTimer()
 | |
| 			for i := 0; i < b.N; i++ {
 | |
| 				dst = test.AppendTo(dst[:0])
 | |
| 			}
 | |
| 		})
 | |
| 	}
 | |
| }
 |