mirror of
				https://github.com/minio/minio.git
				synced 2025-10-31 08:11:19 +01:00 
			
		
		
		
	* Fix cases where minimum timeout > default timeout. * Add defensive code for too small/negative timeouts. * Never set timeout below the maximum value of a request. * Protect against (unlikely) int64 wraps. * Decrease timeout slower. * Don't re-lock before copying.
		
			
				
	
	
		
			234 lines
		
	
	
		
			5.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			234 lines
		
	
	
		
			5.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| /*
 | |
|  * MinIO Cloud Storage, (C) 2017 MinIO, Inc.
 | |
|  *
 | |
|  * Licensed under the Apache License, Version 2.0 (the "License");
 | |
|  * you may not use this file except in compliance with the License.
 | |
|  * You may obtain a copy of the License at
 | |
|  *
 | |
|  *     http://www.apache.org/licenses/LICENSE-2.0
 | |
|  *
 | |
|  * Unless required by applicable law or agreed to in writing, software
 | |
|  * distributed under the License is distributed on an "AS IS" BASIS,
 | |
|  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | |
|  * See the License for the specific language governing permissions and
 | |
|  * limitations under the License.
 | |
|  */
 | |
| 
 | |
| package cmd
 | |
| 
 | |
| import (
 | |
| 	"math/rand"
 | |
| 	"runtime"
 | |
| 	"sync"
 | |
| 	"testing"
 | |
| 	"time"
 | |
| )
 | |
| 
 | |
| func TestDynamicTimeoutSingleIncrease(t *testing.T) {
 | |
| 
 | |
| 	timeout := newDynamicTimeout(time.Minute, time.Second)
 | |
| 
 | |
| 	initial := timeout.Timeout()
 | |
| 
 | |
| 	for i := 0; i < dynamicTimeoutLogSize; i++ {
 | |
| 		timeout.LogFailure()
 | |
| 	}
 | |
| 
 | |
| 	adjusted := timeout.Timeout()
 | |
| 
 | |
| 	if initial >= adjusted {
 | |
| 		t.Errorf("Failure to increase timeout, expected %v to be more than %v", adjusted, initial)
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestDynamicTimeoutDualIncrease(t *testing.T) {
 | |
| 
 | |
| 	timeout := newDynamicTimeout(time.Minute, time.Second)
 | |
| 
 | |
| 	initial := timeout.Timeout()
 | |
| 
 | |
| 	for i := 0; i < dynamicTimeoutLogSize; i++ {
 | |
| 		timeout.LogFailure()
 | |
| 	}
 | |
| 
 | |
| 	adjusted := timeout.Timeout()
 | |
| 
 | |
| 	for i := 0; i < dynamicTimeoutLogSize; i++ {
 | |
| 		timeout.LogFailure()
 | |
| 	}
 | |
| 
 | |
| 	adjustedAgain := timeout.Timeout()
 | |
| 
 | |
| 	if initial >= adjusted || adjusted >= adjustedAgain {
 | |
| 		t.Errorf("Failure to increase timeout multiple times")
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestDynamicTimeoutSingleDecrease(t *testing.T) {
 | |
| 
 | |
| 	timeout := newDynamicTimeout(time.Minute, time.Second)
 | |
| 
 | |
| 	initial := timeout.Timeout()
 | |
| 
 | |
| 	for i := 0; i < dynamicTimeoutLogSize; i++ {
 | |
| 		timeout.LogSuccess(20 * time.Second)
 | |
| 	}
 | |
| 
 | |
| 	adjusted := timeout.Timeout()
 | |
| 
 | |
| 	if initial <= adjusted {
 | |
| 		t.Errorf("Failure to decrease timeout, expected %v to be less than %v", adjusted, initial)
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestDynamicTimeoutDualDecrease(t *testing.T) {
 | |
| 
 | |
| 	timeout := newDynamicTimeout(time.Minute, time.Second)
 | |
| 
 | |
| 	initial := timeout.Timeout()
 | |
| 
 | |
| 	for i := 0; i < dynamicTimeoutLogSize; i++ {
 | |
| 		timeout.LogSuccess(20 * time.Second)
 | |
| 	}
 | |
| 
 | |
| 	adjusted := timeout.Timeout()
 | |
| 
 | |
| 	for i := 0; i < dynamicTimeoutLogSize; i++ {
 | |
| 		timeout.LogSuccess(20 * time.Second)
 | |
| 	}
 | |
| 
 | |
| 	adjustedAgain := timeout.Timeout()
 | |
| 
 | |
| 	if initial <= adjusted || adjusted <= adjustedAgain {
 | |
| 		t.Errorf("Failure to decrease timeout multiple times, initial: %v, adjusted: %v, again: %v", initial, adjusted, adjustedAgain)
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestDynamicTimeoutManyDecreases(t *testing.T) {
 | |
| 
 | |
| 	timeout := newDynamicTimeout(time.Minute, time.Second)
 | |
| 
 | |
| 	initial := timeout.Timeout()
 | |
| 
 | |
| 	const successTimeout = 20 * time.Second
 | |
| 	for l := 0; l < 100; l++ {
 | |
| 		for i := 0; i < dynamicTimeoutLogSize; i++ {
 | |
| 			timeout.LogSuccess(successTimeout)
 | |
| 		}
 | |
| 
 | |
| 	}
 | |
| 
 | |
| 	adjusted := timeout.Timeout()
 | |
| 	// Check whether eventual timeout is between initial value and success timeout
 | |
| 	if initial <= adjusted || adjusted <= successTimeout {
 | |
| 		t.Errorf("Failure to decrease timeout appropriately")
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestDynamicTimeoutConcurrent(t *testing.T) {
 | |
| 	// Race test.
 | |
| 	timeout := newDynamicTimeout(time.Second, time.Millisecond)
 | |
| 	var wg sync.WaitGroup
 | |
| 	for i := 0; i < runtime.GOMAXPROCS(0); i++ {
 | |
| 		wg.Add(1)
 | |
| 		rng := rand.New(rand.NewSource(int64(i)))
 | |
| 		go func() {
 | |
| 			defer wg.Done()
 | |
| 			for i := 0; i < 100; i++ {
 | |
| 				timeout.LogFailure()
 | |
| 				for j := 0; j < 100; j++ {
 | |
| 					timeout.LogSuccess(time.Duration(float64(time.Second) * rng.Float64()))
 | |
| 				}
 | |
| 				to := timeout.Timeout()
 | |
| 				if to < time.Millisecond || to > time.Second {
 | |
| 					panic(to)
 | |
| 				}
 | |
| 			}
 | |
| 		}()
 | |
| 	}
 | |
| 	wg.Wait()
 | |
| }
 | |
| 
 | |
| func TestDynamicTimeoutHitMinimum(t *testing.T) {
 | |
| 
 | |
| 	const minimum = 30 * time.Second
 | |
| 	timeout := newDynamicTimeout(time.Minute, minimum)
 | |
| 
 | |
| 	initial := timeout.Timeout()
 | |
| 
 | |
| 	const successTimeout = 20 * time.Second
 | |
| 	for l := 0; l < 100; l++ {
 | |
| 		for i := 0; i < dynamicTimeoutLogSize; i++ {
 | |
| 			timeout.LogSuccess(successTimeout)
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	adjusted := timeout.Timeout()
 | |
| 	// Check whether eventual timeout has hit the minimum value
 | |
| 	if initial <= adjusted || adjusted != minimum {
 | |
| 		t.Errorf("Failure to decrease timeout appropriately")
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func testDynamicTimeoutAdjust(t *testing.T, timeout *dynamicTimeout, f func() float64) {
 | |
| 
 | |
| 	const successTimeout = 20 * time.Second
 | |
| 
 | |
| 	for i := 0; i < dynamicTimeoutLogSize; i++ {
 | |
| 
 | |
| 		rnd := f()
 | |
| 		duration := time.Duration(float64(successTimeout) * rnd)
 | |
| 
 | |
| 		if duration < 100*time.Millisecond {
 | |
| 			duration = 100 * time.Millisecond
 | |
| 		}
 | |
| 		if duration >= time.Minute {
 | |
| 			timeout.LogFailure()
 | |
| 		} else {
 | |
| 			timeout.LogSuccess(duration)
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestDynamicTimeoutAdjustExponential(t *testing.T) {
 | |
| 
 | |
| 	timeout := newDynamicTimeout(time.Minute, time.Second)
 | |
| 
 | |
| 	rand.Seed(0)
 | |
| 
 | |
| 	initial := timeout.Timeout()
 | |
| 
 | |
| 	for try := 0; try < 10; try++ {
 | |
| 
 | |
| 		testDynamicTimeoutAdjust(t, timeout, rand.ExpFloat64)
 | |
| 
 | |
| 	}
 | |
| 
 | |
| 	adjusted := timeout.Timeout()
 | |
| 	if initial <= adjusted {
 | |
| 		t.Errorf("Failure to decrease timeout, expected %v to be less than %v", adjusted, initial)
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestDynamicTimeoutAdjustNormalized(t *testing.T) {
 | |
| 
 | |
| 	timeout := newDynamicTimeout(time.Minute, time.Second)
 | |
| 
 | |
| 	rand.Seed(0)
 | |
| 
 | |
| 	initial := timeout.Timeout()
 | |
| 
 | |
| 	for try := 0; try < 10; try++ {
 | |
| 
 | |
| 		testDynamicTimeoutAdjust(t, timeout, func() float64 {
 | |
| 			return 1.0 + rand.NormFloat64()
 | |
| 		})
 | |
| 
 | |
| 	}
 | |
| 
 | |
| 	adjusted := timeout.Timeout()
 | |
| 	if initial <= adjusted {
 | |
| 		t.Errorf("Failure to decrease timeout, expected %v to be less than %v", adjusted, initial)
 | |
| 	}
 | |
| }
 |