mirror of
				https://github.com/minio/minio.git
				synced 2025-10-31 08:11:19 +01:00 
			
		
		
		
	Disallow versioning suspension on a bucket with pre-existing replication configuration If versioning is suspended on the target,replication should fail.
		
			
				
	
	
		
			139 lines
		
	
	
		
			4.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			139 lines
		
	
	
		
			4.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| /*
 | |
|  * MinIO Cloud Storage, (C) 2020 MinIO, Inc.
 | |
|  *
 | |
|  * Licensed under the Apache License, Version 2.0 (the "License");
 | |
|  * you may not use this file except in compliance with the License.
 | |
|  * You may obtain a copy of the License at
 | |
|  *
 | |
|  *     http://www.apache.org/licenses/LICENSE-2.0
 | |
|  *
 | |
|  * Unless required by applicable law or agreed to in writing, software
 | |
|  * distributed under the License is distributed on an "AS IS" BASIS,
 | |
|  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | |
|  * See the License for the specific language governing permissions and
 | |
|  * limitations under the License.
 | |
|  */
 | |
| 
 | |
| package cmd
 | |
| 
 | |
| import (
 | |
| 	"encoding/xml"
 | |
| 	"io"
 | |
| 	"net/http"
 | |
| 
 | |
| 	humanize "github.com/dustin/go-humanize"
 | |
| 	"github.com/gorilla/mux"
 | |
| 	"github.com/minio/minio/cmd/logger"
 | |
| 	"github.com/minio/minio/pkg/bucket/policy"
 | |
| 	"github.com/minio/minio/pkg/bucket/versioning"
 | |
| )
 | |
| 
 | |
| const (
 | |
| 	bucketVersioningConfig = "versioning.xml"
 | |
| 
 | |
| 	// Maximum size of bucket versioning configuration payload sent to the PutBucketVersioningHandler.
 | |
| 	maxBucketVersioningConfigSize = 1 * humanize.MiByte
 | |
| )
 | |
| 
 | |
| // PutBucketVersioningHandler - PUT Bucket Versioning.
 | |
| // ----------
 | |
| func (api objectAPIHandlers) PutBucketVersioningHandler(w http.ResponseWriter, r *http.Request) {
 | |
| 	ctx := newContext(r, w, "PutBucketVersioning")
 | |
| 
 | |
| 	defer logger.AuditLog(w, r, "PutBucketVersioning", mustGetClaimsFromToken(r))
 | |
| 
 | |
| 	vars := mux.Vars(r)
 | |
| 	bucket := vars["bucket"]
 | |
| 
 | |
| 	objectAPI := api.ObjectAPI()
 | |
| 	if objectAPI == nil {
 | |
| 		writeErrorResponse(ctx, w, errorCodes.ToAPIErr(ErrServerNotInitialized), r.URL, guessIsBrowserReq(r))
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	if s3Error := checkRequestAuthType(ctx, r, policy.PutBucketVersioningAction, bucket, ""); s3Error != ErrNone {
 | |
| 		writeErrorResponse(ctx, w, errorCodes.ToAPIErr(s3Error), r.URL, guessIsBrowserReq(r))
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	v, err := versioning.ParseConfig(io.LimitReader(r.Body, maxBucketVersioningConfigSize))
 | |
| 	if err != nil {
 | |
| 		writeErrorResponse(ctx, w, toAPIError(ctx, err), r.URL, guessIsBrowserReq(r))
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	if rcfg, _ := globalBucketObjectLockSys.Get(bucket); rcfg.LockEnabled && v.Suspended() {
 | |
| 		writeErrorResponse(ctx, w, APIError{
 | |
| 			Code:           "InvalidBucketState",
 | |
| 			Description:    "An Object Lock configuration is present on this bucket, so the versioning state cannot be changed.",
 | |
| 			HTTPStatusCode: http.StatusConflict,
 | |
| 		}, r.URL, guessIsBrowserReq(r))
 | |
| 		return
 | |
| 	}
 | |
| 	if _, err := getReplicationConfig(ctx, bucket); err == nil && v.Suspended() {
 | |
| 		writeErrorResponse(ctx, w, APIError{
 | |
| 			Code:           "InvalidBucketState",
 | |
| 			Description:    "A replication configuration is present on this bucket, so the versioning state cannot be changed.",
 | |
| 			HTTPStatusCode: http.StatusConflict,
 | |
| 		}, r.URL, guessIsBrowserReq(r))
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	configData, err := xml.Marshal(v)
 | |
| 	if err != nil {
 | |
| 		writeErrorResponse(ctx, w, toAPIError(ctx, err), r.URL, guessIsBrowserReq(r))
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	if err = globalBucketMetadataSys.Update(bucket, bucketVersioningConfig, configData); err != nil {
 | |
| 		writeErrorResponse(ctx, w, toAPIError(ctx, err), r.URL, guessIsBrowserReq(r))
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	writeSuccessResponseHeadersOnly(w)
 | |
| }
 | |
| 
 | |
| // GetBucketVersioningHandler - GET Bucket Versioning.
 | |
| // ----------
 | |
| func (api objectAPIHandlers) GetBucketVersioningHandler(w http.ResponseWriter, r *http.Request) {
 | |
| 	ctx := newContext(r, w, "GetBucketVersioning")
 | |
| 
 | |
| 	defer logger.AuditLog(w, r, "GetBucketVersioning", mustGetClaimsFromToken(r))
 | |
| 
 | |
| 	vars := mux.Vars(r)
 | |
| 	bucket := vars["bucket"]
 | |
| 
 | |
| 	objectAPI := api.ObjectAPI()
 | |
| 	if objectAPI == nil {
 | |
| 		writeErrorResponse(ctx, w, errorCodes.ToAPIErr(ErrServerNotInitialized), r.URL, guessIsBrowserReq(r))
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	if s3Error := checkRequestAuthType(ctx, r, policy.GetBucketVersioningAction, bucket, ""); s3Error != ErrNone {
 | |
| 		writeErrorResponse(ctx, w, errorCodes.ToAPIErr(s3Error), r.URL, guessIsBrowserReq(r))
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	// Check if bucket exists.
 | |
| 	if _, err := objectAPI.GetBucketInfo(ctx, bucket); err != nil {
 | |
| 		writeErrorResponse(ctx, w, toAPIError(ctx, err), r.URL, guessIsBrowserReq(r))
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	config, err := globalBucketVersioningSys.Get(bucket)
 | |
| 	if err != nil {
 | |
| 		writeErrorResponse(ctx, w, toAPIError(ctx, err), r.URL, guessIsBrowserReq(r))
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	configData, err := xml.Marshal(config)
 | |
| 	if err != nil {
 | |
| 		writeErrorResponse(ctx, w, toAPIError(ctx, err), r.URL, guessIsBrowserReq(r))
 | |
| 		return
 | |
| 	}
 | |
| 
 | |
| 	// Write bucket versioning configuration to client
 | |
| 	writeSuccessResponseXML(w, configData)
 | |
| 
 | |
| }
 |