mirror of
				https://github.com/minio/minio.git
				synced 2025-11-04 02:01:05 +01:00 
			
		
		
		
	Ref #3229 After review with @abperiasamy we decided to remove all the unnecessary options - MINIO_BROWSER (Implemented as a security feature but now deemed obsolete since even if blocking access to MINIO_BROWSER, s3 API port is open) - MINIO_CACHE_EXPIRY (Defaults to 72h) - MINIO_MAXCONN (No one used this option and we don't test this) - MINIO_ENABLE_FSMETA (Enable FSMETA all the time) Remove --ignore-disks option - this option was implemented when XL layer would initialize the backend disks and heal them automatically to disallow XL accidentally using the root partition itself this option was introduced. This behavior has been changed XL no longer automatically initializes `format.json` a HEAL is controlled activity, so ignore-disks is not useful anymore. This change also addresses the problems of our documentation going forward and keeps things simple. This patch brings in reduction of options and defaulting them to a valid known inputs. This patch also serves as a guideline of limiting many ways to do the same thing.
		
			
				
	
	
		
			339 lines
		
	
	
		
			7.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			339 lines
		
	
	
		
			7.2 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
/*
 | 
						|
 * Minio Cloud Storage, (C) 2016 Minio, Inc.
 | 
						|
 *
 | 
						|
 * Licensed under the Apache License, Version 2.0 (the "License");
 | 
						|
 * you may not use this file except in compliance with the License.
 | 
						|
 * You may obtain a copy of the License at
 | 
						|
 *
 | 
						|
 *     http://www.apache.org/licenses/LICENSE-2.0
 | 
						|
 *
 | 
						|
 * Unless required by applicable law or agreed to in writing, software
 | 
						|
 * distributed under the License is distributed on an "AS IS" BASIS,
 | 
						|
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | 
						|
 * See the License for the specific language governing permissions and
 | 
						|
 * limitations under the License.
 | 
						|
 */
 | 
						|
 | 
						|
package cmd
 | 
						|
 | 
						|
import (
 | 
						|
	"fmt"
 | 
						|
	"net"
 | 
						|
	"net/http"
 | 
						|
	"net/url"
 | 
						|
	"reflect"
 | 
						|
	"runtime"
 | 
						|
	"testing"
 | 
						|
)
 | 
						|
 | 
						|
// Tests http.Header clone.
 | 
						|
func TestCloneHeader(t *testing.T) {
 | 
						|
	headers := []http.Header{
 | 
						|
		{
 | 
						|
			"Content-Type":   {"text/html; charset=UTF-8"},
 | 
						|
			"Content-Length": {"0"},
 | 
						|
		},
 | 
						|
		{
 | 
						|
			"Content-Length": {"0", "1", "2"},
 | 
						|
		},
 | 
						|
		{
 | 
						|
			"Expires":          {"-1"},
 | 
						|
			"Content-Length":   {"0"},
 | 
						|
			"Content-Encoding": {"gzip"},
 | 
						|
		},
 | 
						|
	}
 | 
						|
	for i, header := range headers {
 | 
						|
		clonedHeader := cloneHeader(header)
 | 
						|
		if !reflect.DeepEqual(header, clonedHeader) {
 | 
						|
			t.Errorf("Test %d failed", i+1)
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
// Tests check duplicates function.
 | 
						|
func TestCheckDuplicates(t *testing.T) {
 | 
						|
	tests := []struct {
 | 
						|
		list       []string
 | 
						|
		err        error
 | 
						|
		shouldPass bool
 | 
						|
	}{
 | 
						|
		// Test 1 - for '/tmp/1' repeated twice.
 | 
						|
		{
 | 
						|
			list:       []string{"/tmp/1", "/tmp/1", "/tmp/2", "/tmp/3"},
 | 
						|
			err:        fmt.Errorf("Duplicate key: \"/tmp/1\" found of count: \"2\""),
 | 
						|
			shouldPass: false,
 | 
						|
		},
 | 
						|
		// Test 2 - for '/tmp/1' repeated thrice.
 | 
						|
		{
 | 
						|
			list:       []string{"/tmp/1", "/tmp/1", "/tmp/1", "/tmp/3"},
 | 
						|
			err:        fmt.Errorf("Duplicate key: \"/tmp/1\" found of count: \"3\""),
 | 
						|
			shouldPass: false,
 | 
						|
		},
 | 
						|
		// Test 3 - empty string.
 | 
						|
		{
 | 
						|
			list:       []string{""},
 | 
						|
			err:        errInvalidArgument,
 | 
						|
			shouldPass: false,
 | 
						|
		},
 | 
						|
		// Test 4 - empty string.
 | 
						|
		{
 | 
						|
			list:       nil,
 | 
						|
			err:        errInvalidArgument,
 | 
						|
			shouldPass: false,
 | 
						|
		},
 | 
						|
		// Test 5 - non repeated strings.
 | 
						|
		{
 | 
						|
			list:       []string{"/tmp/1", "/tmp/2", "/tmp/3"},
 | 
						|
			err:        nil,
 | 
						|
			shouldPass: true,
 | 
						|
		},
 | 
						|
	}
 | 
						|
 | 
						|
	// Validate if function runs as expected.
 | 
						|
	for i, test := range tests {
 | 
						|
		err := checkDuplicateStrings(test.list)
 | 
						|
		if test.shouldPass && err != test.err {
 | 
						|
			t.Errorf("Test: %d, Expected %s got %s", i+1, test.err, err)
 | 
						|
		}
 | 
						|
		if !test.shouldPass && err.Error() != test.err.Error() {
 | 
						|
			t.Errorf("Test: %d, Expected %s got %s", i+1, test.err, err)
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
// Tests maximum object size.
 | 
						|
func TestMaxObjectSize(t *testing.T) {
 | 
						|
	sizes := []struct {
 | 
						|
		isMax bool
 | 
						|
		size  int64
 | 
						|
	}{
 | 
						|
		// Test - 1 - maximum object size.
 | 
						|
		{
 | 
						|
			true,
 | 
						|
			maxObjectSize + 1,
 | 
						|
		},
 | 
						|
		// Test - 2 - not maximum object size.
 | 
						|
		{
 | 
						|
			false,
 | 
						|
			maxObjectSize - 1,
 | 
						|
		},
 | 
						|
	}
 | 
						|
	for i, s := range sizes {
 | 
						|
		isMax := isMaxObjectSize(s.size)
 | 
						|
		if isMax != s.isMax {
 | 
						|
			t.Errorf("Test %d: Expected %t, got %t", i+1, s.isMax, isMax)
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
// Test urlPathSplit.
 | 
						|
func TestURLPathSplit(t *testing.T) {
 | 
						|
	type test struct {
 | 
						|
		urlPath    string
 | 
						|
		bucketName string
 | 
						|
		prefixName string
 | 
						|
	}
 | 
						|
 | 
						|
	testCases := []test{
 | 
						|
		{
 | 
						|
			urlPath:    "/b/c/",
 | 
						|
			bucketName: "b",
 | 
						|
			prefixName: "c/",
 | 
						|
		},
 | 
						|
		{
 | 
						|
			urlPath:    "c/aa",
 | 
						|
			bucketName: "c",
 | 
						|
			prefixName: "aa",
 | 
						|
		},
 | 
						|
		{
 | 
						|
			urlPath:    "",
 | 
						|
			bucketName: "",
 | 
						|
			prefixName: "",
 | 
						|
		},
 | 
						|
		{
 | 
						|
			urlPath:    "/b",
 | 
						|
			bucketName: "b",
 | 
						|
			prefixName: "",
 | 
						|
		},
 | 
						|
	}
 | 
						|
 | 
						|
	for i, testCase := range testCases {
 | 
						|
		bucketName, prefixName := urlPathSplit(testCase.urlPath)
 | 
						|
		if bucketName != testCase.bucketName {
 | 
						|
			t.Errorf("Tets %d: Expected %s, %s", i+1, testCase.bucketName, bucketName)
 | 
						|
		}
 | 
						|
		if prefixName != testCase.prefixName {
 | 
						|
			t.Errorf("Tets %d: Expected %s, %s", i+1, testCase.bucketName, bucketName)
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
// Tests minimum allowed part size.
 | 
						|
func TestMinAllowedPartSize(t *testing.T) {
 | 
						|
	sizes := []struct {
 | 
						|
		isMin bool
 | 
						|
		size  int64
 | 
						|
	}{
 | 
						|
		// Test - 1 - within minimum part size.
 | 
						|
		{
 | 
						|
			true,
 | 
						|
			minPartSize + 1,
 | 
						|
		},
 | 
						|
		// Test - 2 - smaller than minimum part size.
 | 
						|
		{
 | 
						|
			false,
 | 
						|
			minPartSize - 1,
 | 
						|
		},
 | 
						|
	}
 | 
						|
 | 
						|
	for i, s := range sizes {
 | 
						|
		isMin := isMinAllowedPartSize(s.size)
 | 
						|
		if isMin != s.isMin {
 | 
						|
			t.Errorf("Test %d: Expected %t, got %t", i+1, s.isMin, isMin)
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
// Tests maximum allowed part number.
 | 
						|
func TestMaxPartID(t *testing.T) {
 | 
						|
	sizes := []struct {
 | 
						|
		isMax bool
 | 
						|
		partN int
 | 
						|
	}{
 | 
						|
		// Test - 1 part number within max part number.
 | 
						|
		{
 | 
						|
			false,
 | 
						|
			maxPartID - 1,
 | 
						|
		},
 | 
						|
		// Test - 2 part number bigger than max part number.
 | 
						|
		{
 | 
						|
			true,
 | 
						|
			maxPartID + 1,
 | 
						|
		},
 | 
						|
	}
 | 
						|
 | 
						|
	for i, s := range sizes {
 | 
						|
		isMax := isMaxPartID(s.partN)
 | 
						|
		if isMax != s.isMax {
 | 
						|
			t.Errorf("Test %d: Expected %t, got %t", i+1, s.isMax, isMax)
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
// Add tests for starting and stopping different profilers.
 | 
						|
func TestStartProfiler(t *testing.T) {
 | 
						|
	if startProfiler("") != nil {
 | 
						|
		t.Fatal("Expected nil, but non-nil value returned for invalid profiler.")
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
// Tests fetch local address.
 | 
						|
func TestLocalAddress(t *testing.T) {
 | 
						|
	if runtime.GOOS == "windows" {
 | 
						|
		return
 | 
						|
	}
 | 
						|
	// need to set this to avoid stale values from other tests.
 | 
						|
	globalMinioPort = "9000"
 | 
						|
	globalMinioHost = ""
 | 
						|
	testCases := []struct {
 | 
						|
		isDistXL     bool
 | 
						|
		srvCmdConfig serverCmdConfig
 | 
						|
		localAddr    string
 | 
						|
	}{
 | 
						|
		// Test 1 - local address is found.
 | 
						|
		{
 | 
						|
			isDistXL: true,
 | 
						|
			srvCmdConfig: serverCmdConfig{
 | 
						|
				endpoints: []*url.URL{{
 | 
						|
					Scheme: "http",
 | 
						|
					Host:   "localhost:9000",
 | 
						|
					Path:   "/mnt/disk1",
 | 
						|
				}, {
 | 
						|
					Scheme: "http",
 | 
						|
					Host:   "1.1.1.2:9000",
 | 
						|
					Path:   "/mnt/disk2",
 | 
						|
				}, {
 | 
						|
					Scheme: "http",
 | 
						|
					Host:   "1.1.2.1:9000",
 | 
						|
					Path:   "/mnt/disk3",
 | 
						|
				}, {
 | 
						|
					Scheme: "http",
 | 
						|
					Host:   "1.1.2.2:9000",
 | 
						|
					Path:   "/mnt/disk4",
 | 
						|
				}},
 | 
						|
			},
 | 
						|
			localAddr: net.JoinHostPort("localhost", globalMinioPort),
 | 
						|
		},
 | 
						|
		// Test 2 - local address is everything.
 | 
						|
		{
 | 
						|
			isDistXL: false,
 | 
						|
			srvCmdConfig: serverCmdConfig{
 | 
						|
				serverAddr: net.JoinHostPort("", globalMinioPort),
 | 
						|
				endpoints: []*url.URL{{
 | 
						|
					Path: "/mnt/disk1",
 | 
						|
				}, {
 | 
						|
					Path: "/mnt/disk2",
 | 
						|
				}, {
 | 
						|
					Path: "/mnt/disk3",
 | 
						|
				}, {
 | 
						|
					Path: "/mnt/disk4",
 | 
						|
				}},
 | 
						|
			},
 | 
						|
			localAddr: net.JoinHostPort("", globalMinioPort),
 | 
						|
		},
 | 
						|
		// Test 3 - local address is not found.
 | 
						|
		{
 | 
						|
			isDistXL: true,
 | 
						|
			srvCmdConfig: serverCmdConfig{
 | 
						|
				endpoints: []*url.URL{{
 | 
						|
					Scheme: "http",
 | 
						|
					Host:   "1.1.1.1:9000",
 | 
						|
					Path:   "/mnt/disk2",
 | 
						|
				}, {
 | 
						|
					Scheme: "http",
 | 
						|
					Host:   "1.1.1.2:9000",
 | 
						|
					Path:   "/mnt/disk2",
 | 
						|
				}, {
 | 
						|
					Scheme: "http",
 | 
						|
					Host:   "1.1.2.1:9000",
 | 
						|
					Path:   "/mnt/disk3",
 | 
						|
				}, {
 | 
						|
					Scheme: "http",
 | 
						|
					Host:   "1.1.2.2:9000",
 | 
						|
					Path:   "/mnt/disk4",
 | 
						|
				}},
 | 
						|
			},
 | 
						|
			localAddr: "",
 | 
						|
		},
 | 
						|
		// Test 4 - in case of FS mode, with SSL, the host
 | 
						|
		// name is specified in the --address option on the
 | 
						|
		// server command line.
 | 
						|
		{
 | 
						|
			isDistXL: false,
 | 
						|
			srvCmdConfig: serverCmdConfig{
 | 
						|
				serverAddr: "play.minio.io:9000",
 | 
						|
				endpoints: []*url.URL{{
 | 
						|
					Path: "/mnt/disk1",
 | 
						|
				}, {
 | 
						|
					Path: "/mnt/disk2",
 | 
						|
				}, {
 | 
						|
					Path: "/mnt/disk3",
 | 
						|
				}, {
 | 
						|
					Path: "/mnt/disk4",
 | 
						|
				}},
 | 
						|
			},
 | 
						|
			localAddr: "play.minio.io:9000",
 | 
						|
		},
 | 
						|
	}
 | 
						|
 | 
						|
	// Validates fetching local address.
 | 
						|
	for i, testCase := range testCases {
 | 
						|
		globalIsDistXL = testCase.isDistXL
 | 
						|
		localAddr := getLocalAddress(testCase.srvCmdConfig)
 | 
						|
		if localAddr != testCase.localAddr {
 | 
						|
			t.Fatalf("Test %d: Expected %s, got %s", i+1, testCase.localAddr, localAddr)
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
}
 |