mirror of
				https://github.com/minio/minio.git
				synced 2025-10-31 08:11:19 +01:00 
			
		
		
		
	removes contentious usage of mutexes in LRU, which were never really reused in any manner; we do not need it. To trust hosts, the correct way is TLS certs; this PR completely removes this dependency, which has never been useful. ``` 0 0% 100% 25.83s 26.76% github.com/hashicorp/golang-lru/v2/expirable.(*LRU[...]) 0 0% 100% 28.03s 29.04% github.com/hashicorp/golang-lru/v2/expirable.(*LRU[...]) ``` Bonus: use `x-minio-time` as a nanosecond to avoid unnecessary parsing logic of time strings instead of using a more straightforward mechanism.
		
			
				
	
	
		
			191 lines
		
	
	
		
			4.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			191 lines
		
	
	
		
			4.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright (c) 2015-2021 MinIO, Inc.
 | |
| //
 | |
| // This file is part of MinIO Object Storage stack
 | |
| //
 | |
| // This program is free software: you can redistribute it and/or modify
 | |
| // it under the terms of the GNU Affero General Public License as published by
 | |
| // the Free Software Foundation, either version 3 of the License, or
 | |
| // (at your option) any later version.
 | |
| //
 | |
| // This program is distributed in the hope that it will be useful
 | |
| // but WITHOUT ANY WARRANTY; without even the implied warranty of
 | |
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 | |
| // GNU Affero General Public License for more details.
 | |
| //
 | |
| // You should have received a copy of the GNU Affero General Public License
 | |
| // along with this program.  If not, see <http://www.gnu.org/licenses/>.
 | |
| 
 | |
| package cmd
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"net/http"
 | |
| 	"os"
 | |
| 	"testing"
 | |
| 
 | |
| 	jwtgo "github.com/golang-jwt/jwt/v4"
 | |
| 	xjwt "github.com/minio/minio/internal/jwt"
 | |
| )
 | |
| 
 | |
| func getTokenString(accessKey, secretKey string) (string, error) {
 | |
| 	claims := xjwt.NewMapClaims()
 | |
| 	claims.SetExpiry(UTCNow().Add(defaultJWTExpiry))
 | |
| 	claims.SetAccessKey(accessKey)
 | |
| 	token := jwtgo.NewWithClaims(jwtgo.SigningMethodHS512, claims)
 | |
| 	return token.SignedString([]byte(secretKey))
 | |
| }
 | |
| 
 | |
| // Tests web request authenticator.
 | |
| func TestWebRequestAuthenticate(t *testing.T) {
 | |
| 	ctx, cancel := context.WithCancel(context.Background())
 | |
| 	defer cancel()
 | |
| 
 | |
| 	obj, fsDir, err := prepareFS(ctx)
 | |
| 	if err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 	defer os.RemoveAll(fsDir)
 | |
| 	if err = newTestConfig(globalMinioDefaultRegion, obj); err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 
 | |
| 	creds := globalActiveCred
 | |
| 	token, err := getTokenString(creds.AccessKey, creds.SecretKey)
 | |
| 	if err != nil {
 | |
| 		t.Fatalf("unable get token %s", err)
 | |
| 	}
 | |
| 	testCases := []struct {
 | |
| 		req         *http.Request
 | |
| 		expectedErr error
 | |
| 	}{
 | |
| 		// Set valid authorization header.
 | |
| 		{
 | |
| 			req: &http.Request{
 | |
| 				Header: http.Header{
 | |
| 					"Authorization": []string{token},
 | |
| 				},
 | |
| 			},
 | |
| 			expectedErr: nil,
 | |
| 		},
 | |
| 		// No authorization header.
 | |
| 		{
 | |
| 			req: &http.Request{
 | |
| 				Header: http.Header{},
 | |
| 			},
 | |
| 			expectedErr: errNoAuthToken,
 | |
| 		},
 | |
| 		// Invalid authorization token.
 | |
| 		{
 | |
| 			req: &http.Request{
 | |
| 				Header: http.Header{
 | |
| 					"Authorization": []string{"invalid-token"},
 | |
| 				},
 | |
| 			},
 | |
| 			expectedErr: errAuthentication,
 | |
| 		},
 | |
| 	}
 | |
| 
 | |
| 	for i, testCase := range testCases {
 | |
| 		_, _, _, gotErr := metricsRequestAuthenticate(testCase.req)
 | |
| 		if testCase.expectedErr != gotErr {
 | |
| 			t.Errorf("Test %d, expected err %s, got %s", i+1, testCase.expectedErr, gotErr)
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func BenchmarkParseJWTStandardClaims(b *testing.B) {
 | |
| 	ctx, cancel := context.WithCancel(context.Background())
 | |
| 	defer cancel()
 | |
| 
 | |
| 	obj, fsDir, err := prepareFS(ctx)
 | |
| 	if err != nil {
 | |
| 		b.Fatal(err)
 | |
| 	}
 | |
| 	defer os.RemoveAll(fsDir)
 | |
| 	if err = newTestConfig(globalMinioDefaultRegion, obj); err != nil {
 | |
| 		b.Fatal(err)
 | |
| 	}
 | |
| 
 | |
| 	creds := globalActiveCred
 | |
| 	token, err := authenticateNode(creds.AccessKey, creds.SecretKey)
 | |
| 	if err != nil {
 | |
| 		b.Fatal(err)
 | |
| 	}
 | |
| 
 | |
| 	b.ResetTimer()
 | |
| 	b.ReportAllocs()
 | |
| 	b.RunParallel(func(pb *testing.PB) {
 | |
| 		for pb.Next() {
 | |
| 			err = xjwt.ParseWithStandardClaims(token, xjwt.NewStandardClaims(), []byte(creds.SecretKey))
 | |
| 			if err != nil {
 | |
| 				b.Fatal(err)
 | |
| 			}
 | |
| 		}
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func BenchmarkParseJWTMapClaims(b *testing.B) {
 | |
| 	ctx, cancel := context.WithCancel(context.Background())
 | |
| 	defer cancel()
 | |
| 
 | |
| 	obj, fsDir, err := prepareFS(ctx)
 | |
| 	if err != nil {
 | |
| 		b.Fatal(err)
 | |
| 	}
 | |
| 	defer os.RemoveAll(fsDir)
 | |
| 	if err = newTestConfig(globalMinioDefaultRegion, obj); err != nil {
 | |
| 		b.Fatal(err)
 | |
| 	}
 | |
| 
 | |
| 	creds := globalActiveCred
 | |
| 	token, err := authenticateNode(creds.AccessKey, creds.SecretKey)
 | |
| 	if err != nil {
 | |
| 		b.Fatal(err)
 | |
| 	}
 | |
| 
 | |
| 	b.ResetTimer()
 | |
| 	b.ReportAllocs()
 | |
| 	b.RunParallel(func(pb *testing.PB) {
 | |
| 		for pb.Next() {
 | |
| 			err = xjwt.ParseWithClaims(token, xjwt.NewMapClaims(), func(*xjwt.MapClaims) ([]byte, error) {
 | |
| 				return []byte(creds.SecretKey), nil
 | |
| 			})
 | |
| 			if err != nil {
 | |
| 				b.Fatal(err)
 | |
| 			}
 | |
| 		}
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func BenchmarkAuthenticateNode(b *testing.B) {
 | |
| 	ctx, cancel := context.WithCancel(context.Background())
 | |
| 	defer cancel()
 | |
| 
 | |
| 	obj, fsDir, err := prepareFS(ctx)
 | |
| 	if err != nil {
 | |
| 		b.Fatal(err)
 | |
| 	}
 | |
| 	defer os.RemoveAll(fsDir)
 | |
| 	if err = newTestConfig(globalMinioDefaultRegion, obj); err != nil {
 | |
| 		b.Fatal(err)
 | |
| 	}
 | |
| 
 | |
| 	creds := globalActiveCred
 | |
| 	b.Run("uncached", func(b *testing.B) {
 | |
| 		fn := authenticateNode
 | |
| 		b.ResetTimer()
 | |
| 		b.ReportAllocs()
 | |
| 		for i := 0; i < b.N; i++ {
 | |
| 			fn(creds.AccessKey, creds.SecretKey)
 | |
| 		}
 | |
| 	})
 | |
| 	b.Run("cached", func(b *testing.B) {
 | |
| 		fn := newCachedAuthToken()
 | |
| 		b.ResetTimer()
 | |
| 		b.ReportAllocs()
 | |
| 		for i := 0; i < b.N; i++ {
 | |
| 			fn()
 | |
| 		}
 | |
| 	})
 | |
| }
 |