diff --git a/cmd/erasure-healing.go b/cmd/erasure-healing.go index 8e1e58c55..5f0d68953 100644 --- a/cmd/erasure-healing.go +++ b/cmd/erasure-healing.go @@ -622,7 +622,7 @@ func (er erasureObjects) healObject(ctx context.Context, bucket string, object s } - defer er.renameAll(context.Background(), minioMetaTmpBucket, tmpID) + defer er.deleteAll(context.Background(), minioMetaTmpBucket, tmpID) // Rename from tmp location to the actual location. for i, disk := range outDatedDisks { diff --git a/cmd/erasure-multipart.go b/cmd/erasure-multipart.go index fd94b02f7..b50719882 100644 --- a/cmd/erasure-multipart.go +++ b/cmd/erasure-multipart.go @@ -175,21 +175,6 @@ func (er erasureObjects) cleanupStaleUploads(ctx context.Context, expiry time.Du wg.Wait() } -func (er erasureObjects) renameAll(ctx context.Context, bucket, prefix string) { - var wg sync.WaitGroup - for _, disk := range er.getDisks() { - if disk == nil { - continue - } - wg.Add(1) - go func(disk StorageAPI) { - defer wg.Done() - disk.RenameFile(ctx, bucket, prefix, minioMetaTmpDeletedBucket, mustGetUUID()) - }(disk) - } - wg.Wait() -} - func (er erasureObjects) deleteAll(ctx context.Context, bucket, prefix string) { var wg sync.WaitGroup for _, disk := range er.getDisks() { @@ -218,11 +203,12 @@ func (er erasureObjects) cleanupStaleUploadsOnDisk(ctx context.Context, disk Sto uploadIDPath := pathJoin(shaDir, uploadIDDir) fi, err := disk.ReadVersion(ctx, minioMetaMultipartBucket, uploadIDPath, "", false) if err != nil { + er.deleteAll(ctx, minioMetaMultipartBucket, uploadIDPath) return nil } wait := er.deletedCleanupSleeper.Timer(ctx) if now.Sub(fi.ModTime) > expiry { - er.renameAll(ctx, minioMetaMultipartBucket, uploadIDPath) + er.deleteAll(ctx, minioMetaMultipartBucket, uploadIDPath) } wait() return nil @@ -641,7 +627,7 @@ func (er erasureObjects) PutObjectPart(ctx context.Context, bucket, object, uplo var online int defer func() { if online != len(onlineDisks) { - er.renameAll(context.Background(), minioMetaTmpBucket, tmpPart) + er.deleteAll(context.Background(), minioMetaTmpBucket, tmpPart) } }() @@ -1274,7 +1260,7 @@ func (er erasureObjects) AbortMultipartUpload(ctx context.Context, bucket, objec } // Cleanup all uploaded parts. - er.renameAll(ctx, minioMetaMultipartBucket, er.getUploadIDDir(bucket, object, uploadID)) + er.deleteAll(ctx, minioMetaMultipartBucket, er.getUploadIDDir(bucket, object, uploadID)) // Successfully purged. return nil diff --git a/cmd/erasure-object.go b/cmd/erasure-object.go index f62ac08e5..5d859e2da 100644 --- a/cmd/erasure-object.go +++ b/cmd/erasure-object.go @@ -1072,7 +1072,7 @@ func (er erasureObjects) putObject(ctx context.Context, bucket string, object st var online int defer func() { if online != len(onlineDisks) { - er.renameAll(context.Background(), minioMetaTmpBucket, tempObj) + er.deleteAll(context.Background(), minioMetaTmpBucket, tempObj) } }() diff --git a/cmd/erasure-server-pool.go b/cmd/erasure-server-pool.go index c4b33dc35..22db3a992 100644 --- a/cmd/erasure-server-pool.go +++ b/cmd/erasure-server-pool.go @@ -1699,7 +1699,7 @@ func (z *erasureServerPools) DeleteBucket(ctx context.Context, bucket string, op func (z *erasureServerPools) renameAll(ctx context.Context, bucket, prefix string) { for _, servers := range z.serverPools { for _, set := range servers.sets { - set.renameAll(ctx, bucket, prefix) + set.deleteAll(ctx, bucket, prefix) } } }