From b49b39e99dfd1e4e4770a5f6b977591670bda0d5 Mon Sep 17 00:00:00 2001 From: jiuker <2818723467@qq.com> Date: Sat, 25 Feb 2023 16:01:37 +0800 Subject: [PATCH] fix: errNoSuchPolicy should use errors.Is (#16656) --- cmd/api-errors.go | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/cmd/api-errors.go b/cmd/api-errors.go index e7ac9d0c2..2d5180033 100644 --- a/cmd/api-errors.go +++ b/cmd/api-errors.go @@ -2001,8 +2001,6 @@ func toAPIErrorCode(ctx context.Context, err error) (apiErr APIErrorCode) { apiErr = ErrAdminGroupNotEmpty case errNoSuchJob: apiErr = ErrAdminNoSuchJob - case errNoSuchPolicy: - apiErr = ErrAdminNoSuchPolicy case errNoPolicyToAttachOrDetach: apiErr = ErrAdminPolicyChangeAlreadyApplied case errSignatureMismatch: @@ -2054,7 +2052,6 @@ func toAPIErrorCode(ctx context.Context, err error) (apiErr APIErrorCode) { apiErr = ErrKMSKeyNotFoundException case errKMSDefaultKeyAlreadyConfigured: apiErr = ErrKMSDefaultKeyAlreadyConfigured - case context.Canceled, context.DeadlineExceeded: apiErr = ErrOperationTimedOut case errDiskNotFound: @@ -2069,6 +2066,11 @@ func toAPIErrorCode(ctx context.Context, err error) (apiErr APIErrorCode) { apiErr = ErrObjectLockInvalidHeaders case objectlock.ErrMalformedXML: apiErr = ErrMalformedXML + default: + switch { + case errors.Is(err, errNoSuchPolicy): + apiErr = ErrAdminNoSuchPolicy + } } // Compression errors