From acf46cc3b5931aae893c26c307deed62bd1d5c9b Mon Sep 17 00:00:00 2001 From: Praveen raj Mani Date: Tue, 23 Oct 2018 00:21:26 +0530 Subject: [PATCH] SetConfigHandler should avoid setting an invalid notification config (#6679) Fixes #6642 Fixes #6641 --- cmd/admin-handlers.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/cmd/admin-handlers.go b/cmd/admin-handlers.go index 1d111c6be..e77a787d1 100644 --- a/cmd/admin-handlers.go +++ b/cmd/admin-handlers.go @@ -1114,6 +1114,11 @@ func (a adminAPIHandlers) SetConfigHandler(w http.ResponseWriter, r *http.Reques return } + if err = config.TestNotificationTargets(); err != nil { + writeCustomErrorResponseJSON(w, ErrAdminConfigBadJSON, err.Error(), r.URL) + return + } + if err = saveServerConfig(ctx, objectAPI, &config); err != nil { writeErrorResponseJSON(w, toAdminAPIErrCode(err), r.URL) return