From 5aba2aedb37e585060758d7476e294c66e225394 Mon Sep 17 00:00:00 2001 From: Shireesh Anjal <355479+anjalshireesh@users.noreply.github.com> Date: Fri, 21 Oct 2022 13:04:32 +0530 Subject: [PATCH] Do not freeze s3 traffic in healthinfo api (#15912) --- cmd/admin-handlers.go | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/cmd/admin-handlers.go b/cmd/admin-handlers.go index d91d8c585..831ba5a6d 100644 --- a/cmd/admin-handlers.go +++ b/cmd/admin-handlers.go @@ -1988,12 +1988,6 @@ func (a adminAPIHandlers) HealthInfoHandler(w http.ResponseWriter, r *http.Reque healthCtx, healthCancel := context.WithTimeout(lkctx.Context(), deadline) defer healthCancel() - // Freeze all incoming S3 API calls before running speedtest. - globalNotificationSys.ServiceFreeze(ctx, true) - - // unfreeze all incoming S3 API calls after speedtest. - defer globalNotificationSys.ServiceFreeze(ctx, false) - hostAnonymizer := createHostAnonymizer() // anonAddr - Anonymizes hosts in given input string. anonAddr := func(addr string) string { @@ -2139,7 +2133,10 @@ func (a adminAPIHandlers) HealthInfoHandler(w http.ResponseWriter, r *http.Reque if !globalIsDistErasure { // FS mode - single server - hard code to `server1` anonCmdLine := strings.ReplaceAll(cmdLine, globalLocalNodeName, "server1") - return strings.ReplaceAll(anonCmdLine, globalMinioConsoleHost, "server1") + if len(globalMinioConsoleHost) > 0 { + anonCmdLine = strings.ReplaceAll(anonCmdLine, globalMinioConsoleHost, "server1") + } + return anonCmdLine } // Server start command regex groups: