From c39c13b6cf30dbf3aa46d735fa6e54b64c752380 Mon Sep 17 00:00:00 2001 From: rillion <35527671+rillion@users.noreply.github.com> Date: Fri, 16 Nov 2018 07:42:31 +0200 Subject: [PATCH] No reason to restrict Peer ASN's to private only. (#576) * No reason to restrict Peer ASN's to private only. This change is to restrict to public and private ranges. * gofmt --- pkg/controllers/routing/bgp_peers.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/pkg/controllers/routing/bgp_peers.go b/pkg/controllers/routing/bgp_peers.go index 0aa79a0d..a120011e 100644 --- a/pkg/controllers/routing/bgp_peers.go +++ b/pkg/controllers/routing/bgp_peers.go @@ -257,9 +257,12 @@ func newGlobalPeers(ips []net.IP, ports []uint16, asns []uint32, passwords []str } for i := 0; i < len(ips); i++ { - if !((asns[i] >= 64512 && asns[i] <= 65535) || + if !((asns[i] >= 1 && asns[i] <= 23455) || + (asns[i] >= 23457 && asns[i] <= 63999) || + (asns[i] >= 64512 && asns[i] <= 65534) || + (asns[i] >= 131072 && asns[i] <= 4199999999) || (asns[i] >= 4200000000 && asns[i] <= 4294967294)) { - return nil, fmt.Errorf("Invalid ASN number \"%d\" for global BGP peer", + return nil, fmt.Errorf("Reserved ASN number \"%d\" for global BGP peer", asns[i]) }