mirrors/kube-router
1
0
Fork 0
mirror of https://github.com/cloudnativelabs/kube-router.git synced 2025-11-18 19:41:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

feat(NSC): add endpoints that are ready or serving

Browse Source 
In order to be compliant with upstream network implementation
expectations we choose to proxy an endpoint as long as it is either
ready OR serving. This means that endpoints that are terminating will
still be proxied which makes kube-router conformant with the upstream
e2e tests.
This commit is contained in:
Aaron U'Ren 2024-03-01 10:39:38 -06:00 committed by Aaron U'Ren
parent efddb2ea2f
commit 16daa08c7b
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/controllers/proxy/network_services_controller.go
View File

@ -1081,12 +1081,12 @@ func (nsc *NetworkServicesController) buildEndpointSliceInfo() endpointSliceInfo
// protocol: TCP // protocol: TCP
// //
for _, ep := range es.Endpoints { for _, ep := range es.Endpoints {
// Previously, when we used endpoints, we only looked at subsets.addresses and not subsets.notReadyAddresses // We should only look at serving or ready if we want to be compliant with the upstream expectantions of a
// so here we need to limit our endpoints to only the ones that are ready. In the future, we could consider // network provider
// changing this to .Serving which continues to include pods that are in Terminating state. For now we keep if (ep.Conditions.Serving == nil || !*ep.Conditions.Serving) &&
// it the same. (ep.Conditions.Ready == nil || !*ep.Conditions.Ready) {
if ep.Conditions.Ready == nil || !*ep.Conditions.Ready { klog.V(2).Infof("Endpoint (with addresses %s) does not have a ready or serving status, skipping...",
klog.V(2).Infof("Endpoint (with addresses %s) does not have a ready status, skipping...", ep.Addresses) ep.Addresses)
continue continue
} }