From 031d75265b0b448d06df630da5285531eaca8c3d Mon Sep 17 00:00:00 2001 From: Aaron U'Ren Date: Sat, 24 Jul 2021 18:18:56 -0500 Subject: [PATCH] feat(NPC): minor performance improvement Don't continue the loop if we've already matched. --- pkg/controllers/netpol/network_policy_controller.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/controllers/netpol/network_policy_controller.go b/pkg/controllers/netpol/network_policy_controller.go index cc719f90..74f2d5c0 100644 --- a/pkg/controllers/netpol/network_policy_controller.go +++ b/pkg/controllers/netpol/network_policy_controller.go @@ -441,11 +441,13 @@ func (npc *NetworkPolicyController) cleanupStaleRules(activePolicyChains, active } if _, ok := activePolicyChains[chain]; !ok { cleanupPolicyChains = append(cleanupPolicyChains, chain) + continue } } if strings.HasPrefix(chain, kubePodFirewallChainPrefix) { if _, ok := activePodFwChains[chain]; !ok { cleanupPodFwChains = append(cleanupPodFwChains, chain) + continue } } }