From 8c965a9f1623599c687fc0ca7572bf96aed8675f Mon Sep 17 00:00:00 2001 From: iwilltry42 Date: Thu, 26 Sep 2019 18:19:34 +0200 Subject: [PATCH] add missing errchecks --- cmd/create/create.go | 6 +++++- cmd/create/createCluster.go | 4 +++- cmd/create/createNode.go | 4 +++- cmd/delete/deleteNode.go | 4 +++- 4 files changed, 14 insertions(+), 4 deletions(-) diff --git a/cmd/create/create.go b/cmd/create/create.go index f5b0d190..b18eedf5 100644 --- a/cmd/create/create.go +++ b/cmd/create/create.go @@ -22,6 +22,7 @@ THE SOFTWARE. package create import ( + log "github.com/sirupsen/logrus" "github.com/spf13/cobra" ) @@ -34,7 +35,10 @@ func NewCmdCreate() *cobra.Command { Short: "Create a resource [cluster, node].", Long: `Create a resource [cluster, node].`, Run: func(cmd *cobra.Command, args []string) { - cmd.Help() + if err := cmd.Help(); err != nil { + log.Errorln("Couldn't get help text") + log.Fatalln(err) + } }, } diff --git a/cmd/create/createCluster.go b/cmd/create/createCluster.go index 00a856f5..a9b2bf6e 100644 --- a/cmd/create/createCluster.go +++ b/cmd/create/createCluster.go @@ -41,7 +41,9 @@ func NewCmdCreateCluster() *cobra.Command { Long: `Create a new k3s cluster with containerized nodes (k3s in docker).`, Run: func(cmd *cobra.Command, args []string) { runtime, cluster := parseCmd(cmd, args) - k3dCluster.CreateCluster(cluster, runtime) + if err := k3dCluster.CreateCluster(cluster, runtime); err != nil { + log.Fatalln(err) + } }, } diff --git a/cmd/create/createNode.go b/cmd/create/createNode.go index 5493527b..c1d3968d 100644 --- a/cmd/create/createNode.go +++ b/cmd/create/createNode.go @@ -43,7 +43,9 @@ func NewCmdCreateNode() *cobra.Command { if err != nil { log.Debugln("runtime not defined") } - cluster.CreateNode(&k3d.Node{}, rt) + if err := cluster.CreateNode(&k3d.Node{}, rt); err != nil { + log.Fatalln(err) + } }, } diff --git a/cmd/delete/deleteNode.go b/cmd/delete/deleteNode.go index b8ea9865..a97ba92f 100644 --- a/cmd/delete/deleteNode.go +++ b/cmd/delete/deleteNode.go @@ -42,7 +42,9 @@ func NewCmdDeleteNode() *cobra.Command { if err != nil { log.Debugln("runtime not defined") } - cluster.DeleteNode(&k3d.Node{Name: "test"}, rt) + if err := cluster.DeleteNode(&k3d.Node{Name: "test"}, rt); err != nil { + log.Fatalln(err) + } }, }