mirrors/ipxe
1
0
Fork 0
mirror of https://github.com/ipxe/ipxe.git synced 2026-05-05 04:16:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

[bnxt] Fix memory leak in probe()

Browse Source 
Fix potential memory leak in probe() if initialization fails after
HWRM memory has been allocated.

Signed-off-by: Joseph Wong <joseph.wong@broadcom.com>
This commit is contained in:
Joseph Wong 2026-02-23 14:03:47 -08:00 committed by Michael Brown
parent a6d393ecc8
commit f0ceb70cb9
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/drivers/net/bnxt/bnxt.c
View File

@ -2816,18 +2816,18 @@ static int bnxt_init_one ( struct pci_device *pci )
bnxt_get_pci_info ( bp );
/* Allocate HWRM memory */
bnxt_alloc_hwrm_mem ( bp );
if ( ( err = bnxt_alloc_hwrm_mem ( bp ) ) != 0 )
goto err_alloc_hwrm;
bp->link_status = STATUS_LINK_DOWN;
bp->wait_link_timeout = LINK_DEFAULT_TIMEOUT;
if ( bnxt_up_init ( bp ) != 0 ) {
goto err_down_chip;
}
if ( ( err = bnxt_up_init ( bp ) ) != 0 )
goto err_up_init;
/* Register Network device */
if ( ( err = register_netdev ( netdev ) ) != 0 ) {
DBGP ( "- %s ( ): register_netdev Failed\n", __func__ );
goto err_down_chip;
goto err_register_netdev;
}
/* Set Initial Link State */
@ -2836,12 +2836,13 @@ static int bnxt_init_one ( struct pci_device *pci )
return 0;
unregister_netdev ( netdev );
err_down_chip:
err_register_netdev:
err_up_init:
bnxt_free_hwrm_mem ( bp );
err_alloc_hwrm:
bnxt_down_pci ( bp );
netdev_nullify ( netdev );
netdev_put ( netdev );
disable_pdev:
pci_set_drvdata ( pci, NULL );
return err;