mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2026-05-08 22:46:10 +02:00
782336c21b
This reverts commit 64383e655b23e1240dd0043a18ca020994c60022. As reported by Alexander Stephan in issue #3351, it causes problems. First, as seen in the issue, the "reload" operation, handled by an applet local to the master process, is being interrupted by the timeout so that the client never gets the result (though the timeout is applied). A fix for this was found (ignore client-fin/server-fin on applets, as they make no sense there), but it only hides a deeper problem. Indeed, issuing "@1 debug dev delay 2000" still stops at 1s with an error, indicating that commands are systematically being sent with a shutdown, and thus that the server-fin always applies. This is a problem because it means that any long command will now be interrupted after one second. All of this needs to be put back into perspective before progressing further on this issue, and the reason for sending the shutdown should be reconsidered in the context of the current version, as it looks like this was once necessary but no longer is. In addition, the issue encountered by Alexander, of a frozen worker, was essentially reported once in many years, so it's totally acceptable to leave older versions unfixed and figure what's the best solution for modern versions only. Let's just revert to the pre-fix situation so as to avoid causing breakage everywhere. This revert should be backported to all versions (2.4 included).