mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-09-21 22:01:31 +02:00
fe3726cb76
CONNECTION_CLOSE_APP encoding is broken, which prevents the sending of every packet with such a frame. This bug was always present in quic haproxy. However, it was slightly dissimulated by the previous code which always initialized all frame members to zero, which was sufficient to ensure CONNECTION_CLOSE_APP encoding was ok. The below patch changes this behavior by removing this costly initialization step. 4cf784f38ed20b42f6e71bd8a2e8157b95329ee5 MINOR: quic: Avoid zeroing frame structures Now, frames members must always be initialized individually given the type of frame to used. However, for CONNECTION_CLOSE_APP this was not done as qc_cc_build_frm() accessed the wrong union member refering to a CONNECTION_CLOSE instead. This bug was detected when trying to generate a HTTP/3 error. The CONNECTION_CLOSE_APP frame encoding failed due to a non-initialized <reason_phrase_len> which was too big. This was reported by the following trace : "frame building error : qc@0x5555561b86c0 idle_timer_task@0x5555561e5050 flags=0x86038058 CONNECTION_CLOSE_APP" This must be backported up to 2.6. This is necessary even if above commit is not as previous code is also buggy, albeit with a different behavior.
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)