Willy Tarreau f34a3fa33d BUG/MEDIUM: thread: mask stopping_threads with threads_enabled when checking it ...

When soft-stopping, there's a comparison between stopping_threads and
threads_enabled to make sure all threads are stopped, but this is not
correct and is racy since the threads_enabled bit is removed when a
thread is stopped but not its stopping_threads bit. The consequence is
that depending on timing, when stopping, if the first stopping thread
is fast enough to remove its bit from threads_enabled, the other threads
will see that stopping_threads doesn't match threads_enabled anymore and
will wait forever. As such the mask must be applied to stopping_threads
during the test. This issue was introduced in recent commit ef422ced9
("MEDIUM: thread: make stopping_threads per-group and add stopping_tgroups"),
no backport is needed.

2022-07-06 10:19:46 +02:00

..

acl.c

MINOR: acl: alphanumerically sort the ACL dump

2022-03-30 11:49:59 +02:00

action.c

BUG/MINOR: rules: Fix check_capture() function to use the right rule arguments

2022-04-25 15:28:21 +02:00

activity.c

MINOR: thread: only use atomic ops to touch the flags

2022-07-01 19:15:14 +02:00

applet.c

MINOR: applet: always use task_new_on() on applet creation

2022-07-01 19:15:14 +02:00

arg.c

MINOR: arg: Be able to forbid unresolved args when building an argument list

2021-09-30 16:37:05 +02:00

auth.c

…

backend.c

CLEANUP: stconn: replace a few remaining occurrences of CS in comments or traces

2022-05-27 19:33:35 +02:00

base64.c

BUG/MINOR: base64: base64urldec() ignores padding in output size check

2021-08-25 16:14:14 +02:00

cache.c

CLEANUP: applet: rename appctx_cs() to appctx_sc()

2022-05-27 19:33:35 +02:00

calltrace.c

BUILD: calltrace: fix wrong include when building with TRACE=1

2022-04-19 08:23:30 +02:00

cbuf.c

CLEANUP: pool/tree-wide: remove suffix "_pool" from certain pool names

2022-06-23 11:49:09 +02:00

cfgcond.c

MINOR: ssl: Add ssllib_name_startswith precondition

2021-10-13 11:28:08 +02:00

cfgdiag.c

…

cfgparse-global.c

MINOR: config: Add "cluster-secret" new global keyword

2022-05-12 17:48:35 +02:00

cfgparse-listen.c

MINOR: config: use the new bind_parse_args_list() to parse a "bind" line

2022-05-20 18:39:43 +02:00

cfgparse-quic.c

MINOR: quic: Connection TX buffer setting renaming.

2022-05-30 09:59:26 +02:00

cfgparse-ssl.c

MINOR: listener/ssl: set the SSL xprt layer only once the whole config is known

2022-05-20 18:41:55 +02:00

cfgparse-tcp.c

CLEANUP: tree-wide: remove 25 occurrences of unneeded fcntl.h

2022-04-26 10:59:48 +02:00

cfgparse-unix.c

CLEANUP: tree-wide: remove 25 occurrences of unneeded fcntl.h

2022-04-26 10:59:48 +02:00

cfgparse.c

BUG/MEDIUM: peers/config: properly set the thread mask

2022-07-05 19:10:26 +02:00

channel.c

CLEANUP: conn_stream: tree-wide rename to stconn (stream connector)

2022-05-27 19:33:34 +02:00

check.c

MINOR: task: replace task_set_affinity() with task_set_thread()

2022-07-01 19:15:14 +02:00

chunk.c

CLEANUP: chunks: release trash also in deinit

2022-04-27 17:55:41 +02:00

cli.c

BUG/MEDIUM: cli: Notify cli applet won't consume data during request processing

2022-06-13 14:33:30 +02:00

clock.c

MINOR: clock: use ltid_bit in clock_report_idle()

2022-07-01 19:15:15 +02:00

compression.c

CLEANUP: compression: move the default setting of maxzlibmem to defaults

2022-04-25 19:42:43 +02:00

connection.c

MINOR: connection: support HTTP/3.0 for smp_*_http_major fetch

2022-06-07 12:04:12 +02:00

cpuset.c

BUILD: cpuset: do not use const on the source of CPU_AND/CPU_ASSIGN

2022-01-28 19:04:02 +01:00

debug.c

BUILD: debug: re-export thread_dump_state

2022-07-01 21:18:03 +02:00

dgram.c

…

dict.c

…

dns.c

MINOR: thread: get rid of MAX_THREADS_MASK

2022-06-14 11:18:40 +02:00

dynbuf.c

REORG: thread/sched: move the last dynamic thread_info to thread_ctx

2021-10-08 17:22:26 +02:00

eb32sctree.c

…

eb32tree.c

…

eb64tree.c

…

ebimtree.c

…

ebistree.c

…

ebmbtree.c

CLEANUP: assorted typo fixes in the code and comments

2021-08-16 12:37:59 +02:00

ebpttree.c

…

ebsttree.c

…

ebtree.c

…

errors.c

CLEANUP: ring: pass the ring watch flags to ring_attach_cli(), not in ctx.cli

2022-05-06 18:13:36 +02:00

ev_epoll.c

MINOR: poller: centralize poll return handling

2022-07-01 19:15:14 +02:00

ev_evports.c

MINOR: poller: centralize poll return handling

2022-07-01 19:15:14 +02:00

ev_kqueue.c

MINOR: poller: centralize poll return handling

2022-07-01 19:15:14 +02:00

ev_poll.c

MINOR: poller: centralize poll return handling

2022-07-01 19:15:14 +02:00

ev_select.c

MINOR: poller: centralize poll return handling

2022-07-01 19:15:14 +02:00

extcheck.c

MINOR: task: replace task_set_affinity() with task_set_thread()

2022-07-01 19:15:14 +02:00

fcgi-app.c

MEDIUM: http-ana: Add a proxy option to restrict chars in request header names

2022-05-16 16:00:26 +02:00

fcgi.c

CLEANUP: Reapply ist.cocci with --include-headers-for-types --recursive-includes

2022-03-21 08:30:47 +01:00

fd.c

MEDIUM: tasks/fd: replace sleeping_thread_mask with a TH_FL_SLEEPING flag

2022-07-01 19:15:14 +02:00

filters.c

CLEANUP: tree-wide: Remove any ref to stream-interfaces

2022-04-13 15:10:16 +02:00

fix.c

CLEANUP: assorted typo fixes in the code and comments

2021-08-16 12:37:59 +02:00

flt_bwlim.c

CLEANUP: bwlim: Set pointers to NULL when memory is released

2022-07-06 09:34:54 +02:00

flt_http_comp.c

BUG/MEDIUM: compression: Don't forget to update htx_sl and http_msg flags

2022-04-15 16:22:33 +02:00

flt_spoe.c

CLEANUP: applet: rename appctx_cs() to appctx_sc()

2022-05-27 19:33:35 +02:00

flt_trace.c

CLEANUP: Apply ist.cocci

2021-11-08 12:08:26 +01:00

freq_ctr.c

MINOR: freq_ctr: Add a function to get events excess over the current period

2022-06-22 18:33:27 +02:00

frontend.c

REORG: rename cs_utils.h to sc_strm.h

2022-05-27 19:33:35 +02:00

h1_htx.c

BUG/MEDIUM: http: Properly reject non-HTTP/1.x protocols

2022-05-24 15:38:05 +02:00

h1.c

CLEANUP: Reapply ist.cocci with --include-headers-for-types --recursive-includes

2022-03-21 08:30:47 +01:00

h2.c

CLEANUP: Reapply ist.cocci with --include-headers-for-types --recursive-includes

2022-03-21 08:30:47 +01:00

h3_stats.c

MINOR: h3: Add a statistics module for h3

2022-05-30 09:59:26 +02:00

h3.c

MEDIUM: mux-quic: refactor streams opening

2022-07-05 16:18:27 +02:00

haproxy.c

BUG/MEDIUM: thread: mask stopping_threads with threads_enabled when checking it

2022-07-06 10:19:46 +02:00

hash.c

…

hlua_fcn.c

CLEANUP: Add missing header to hlua_fcn.c

2022-05-17 11:40:33 +02:00

hlua.c

CLEANUP: task: remove thread_mask from the struct task

2022-07-01 19:15:14 +02:00

hpack-dec.c

BUILD/DEBUG: hpack: use unsigned int in printf format in debug code

2022-04-12 08:40:38 +02:00

hpack-enc.c

…

hpack-huff.c

OPTIM: hpack: read 32 bits at once when possible.

2022-04-01 17:29:06 +02:00

hpack-tbl.c

BUILD/DEBUG: hpack-tbl: fix format string in standalone debug code

2022-04-12 08:30:08 +02:00

hq_interop.c

MINOR: mux-quic/h3: adjust demuxing function return values

2022-06-07 18:15:47 +02:00

http_acl.c

…

http_act.c

BUG/MINOR: http-act: Properly generate 103 responses when several rules are used

2022-07-06 09:37:43 +02:00

http_ana.c

BUG/MINOR: http-ana: Set method to HTTP_METH_OTHER when an HTTP txn is created

2022-06-22 17:50:54 +02:00

http_client.c

MEDIUM: httpclient: Don't close CLI applet at the end of a response

2022-06-01 17:20:57 +02:00

http_conv.c

BUG/MEDIUM: http-conv: Fix url_enc() to not crush const samples

2022-04-08 10:12:59 +02:00

http_fetch.c

BUG/MINOR: http-fetch: Use integer value when possible in "method" sample fetch

2022-06-22 17:50:54 +02:00

http_htx.c

CLEANUP: Destroy http_err_chunks members during deinit

2022-04-26 23:39:43 +02:00

http_rules.c

BUILD: http: remove the two unused constructors in rules and ana

2022-04-25 19:26:26 +02:00

http.c

MEDIUM: h1: enlarge the scope of accepted version chars with accept-invalid-http-request

2022-05-24 15:38:54 +02:00

htx.c

BUG/MEDIUM: htx: Fix a possible null derefs in htx_xfer_blks()

2022-02-28 17:16:55 +01:00

init.c

MINOR: init: add the pre-check callback

2022-04-22 15:45:47 +02:00

jwt.c

BUG/MINOR: jwt: Memory leak if same key is used in multiple jwt_verify calls

2022-02-15 20:08:20 +01:00

lb_chash.c

…

lb_fas.c

…

lb_fwlc.c

BUG/MEDIUM: leastconn: fix rare possibility of divide by zero

2021-09-22 07:24:02 +02:00

lb_fwrr.c

CLEANUP: assorted typo fixes in the code and comments

2021-08-16 12:37:59 +02:00

lb_map.c

…

listener.c

MINOR: thread: only use atomic ops to touch the flags

2022-07-01 19:15:14 +02:00

log.c

BUG/MINOR: log: Properly test connection retries to fix dontlog-normal option

2022-06-17 14:53:21 +02:00

lru.c

BUILD/DEBUG: lru: fix printf format in debug code

2022-04-12 08:19:33 +02:00

mailers.c

BUG/MEDIUM: mailers: Set the object type for check attached to an email alert

2022-06-08 15:28:38 +02:00

map.c

CLEANUP: applet: rename appctx_cs() to appctx_sc()

2022-05-27 19:33:35 +02:00

mjson.c

…

mqtt.c

MEDIUM: mqtt: support mqtt_is_valid and mqtt_field_value converters for MQTTv3.1

2022-03-22 09:25:52 +01:00

mux_fcgi.c

BUILD: htx: use the unchecked version of htx_get_head_blk() where needed

2022-05-30 16:27:48 +02:00

mux_h1.c

CLEANUP: muxes: Consider stream's sd as defined in .show_fd callback functions

2022-05-30 08:45:16 +02:00

mux_h2.c

CLEANUP: h2: Typo fix in h2_unsubcribe() traces

2022-06-30 14:34:32 +02:00

mux_pt.c

CLEANUP: mux-pt: rename the "endp" field to "sd"

2022-05-27 19:33:35 +02:00

mux_quic.c

MINOR: mux-quic: emit FINAL_SIZE_ERROR on invalid STREAM size

2022-07-05 16:44:01 +02:00

mworker-prog.c

BUILD: mworker: include tools.h for platforms without unsetenv()

2022-01-28 19:04:02 +01:00

mworker.c

CLEANUP: mworker: rename mworker_pipe to mworker_sockpair

2022-07-05 09:06:04 +02:00

namespace.c

…

ncbuf.c

MINOR: ncbuf: implement ncb_is_fragmented()

2022-07-01 15:54:23 +02:00

pattern.c

CLEANUP: Add haproxy/xxhash.h to avoid modifying import/xxhash.h

2021-09-11 19:58:45 +02:00

payload.c

CLEANUP: check: rename all occurrences of stconn "cs" to "sc"

2022-05-27 19:33:35 +02:00

peers.c

MAJOR: task: use t->tid instead of ffsl(t->thread_mask) to take the thread ID

2022-07-01 19:15:14 +02:00

pipe.c

…

pool.c

REORG: stconn: rename conn_stream.{c,h} to stconn.{c,h}

2022-05-27 19:33:35 +02:00

proto_quic.c

CLEANUP: pool/tree-wide: remove suffix "_pool" from certain pool names

2022-06-23 11:49:09 +02:00

proto_sockpair.c

MINOR: protocol: replace ctrl_type with xprt_type and clarify it

2022-05-20 18:39:43 +02:00

proto_tcp.c

MINOR: protocol: replace ctrl_type with xprt_type and clarify it

2022-05-20 18:39:43 +02:00

proto_udp.c

MINOR: protocol: replace ctrl_type with xprt_type and clarify it

2022-05-20 18:39:43 +02:00

proto_uxdg.c

MINOR: protocol: replace ctrl_type with xprt_type and clarify it

2022-05-20 18:39:43 +02:00

proto_uxst.c

MINOR: protocol: replace ctrl_type with xprt_type and clarify it

2022-05-20 18:39:43 +02:00

protocol.c

MINOR: protocol: replace ctrl_type with xprt_type and clarify it

2022-05-20 18:39:43 +02:00

proxy.c

MINOR: proxy: use tg->threads_enabled in hard_stop() to detect stopped threads

2022-07-04 14:09:39 +02:00

qpack-dec.c

MINOR: qpack: properly handle invalid dynamic table references

2022-06-30 11:51:06 +02:00

qpack-enc.c

BUG/MINOR: qpack: support bigger prefix-integer encoding

2022-05-30 14:30:05 +02:00

qpack-tbl.c

CLEANUP: tree-wide: remove a few rare non-ASCII chars

2022-03-04 08:58:32 +01:00

queue.c

MEDIUM: queue: revert to regular inter-task wakeups

2022-07-01 19:15:14 +02:00

quic_cc_newreno.c

CLEANUP: quic: Remove window redundant variable from NewReno algorithm state struct

2022-03-04 17:47:32 +01:00

quic_cc.c

CLEANUP: tree-wide: remove a few rare non-ASCII chars

2022-03-04 08:58:32 +01:00

quic_frame.c

BUILD: quic+h3: 32-bit compilation errors fixes

2022-06-24 12:13:53 +02:00

quic_loss.c

MINOR: quic_stats: Add transport new counters (lost, stateless reset, drop)

2022-05-30 09:59:26 +02:00

quic_sock.c

MINOR: quic: Improvements for the datagrams receipt

2022-06-30 14:34:27 +02:00

quic_stats.c

MINOR: quic: Add new stats counter to diagnose RX buffer overrun

2022-06-30 14:24:04 +02:00

quic_stream.c

CLEANUP: quic: drop the name "conn_stream" from the pool variable names

2022-05-27 19:33:35 +02:00

quic_tls.c

CLEANUP: quic: Remove any reference to boringssl

2022-06-16 15:58:48 +02:00

quic_tp.c

MINOR: quic: Dump version_information transport parameter

2022-06-21 11:07:39 +02:00

raw_sock.c

MINOR: tree-wide: always consider EWOULDBLOCK in addition to EAGAIN

2022-04-25 20:32:15 +02:00

regex.c

…

resolvers.c

BUG/MINOR: server: do not enable DNS resolution on disabled proxies

2022-06-10 11:17:27 +02:00

ring.c

CLEANUP: applet: rename appctx_cs() to appctx_sc()

2022-05-27 19:33:35 +02:00

sample.c

BUG/MEDIUM: sample: Fix adjusting size in word converter

2022-05-27 19:33:34 +02:00

server_state.c

BUILD: server-state: avoid using not-so-portable isblank()

2022-01-28 19:04:02 +01:00

server.c

MINOR: server: indicate when no address was expected for a server

2022-05-31 09:25:34 +02:00

session.c

BUG/MINOR: session: fix theoretical risk of memleak in session_accept_fd()

2022-03-11 07:25:11 +01:00

sha1.c

…

shctx.c

MINOR: shctx: add a few BUG_ON() for consistency checks

2021-11-19 19:25:13 +01:00

signal.c

…

sink.c

CLEANUP: applet: rename appctx_cs() to appctx_sc()

2022-05-27 19:33:35 +02:00

slz.c

IMPORT: slz: use the correct CRC32 instruction when running in 32-bit mode

2021-12-06 09:14:20 +01:00

sock_inet.c

CLEANUP: tree-wide: use fd_set_nonblock() and fd_set_cloexec()

2022-04-26 10:59:48 +02:00

sock_unix.c

CLEANUP: tree-wide: use fd_set_nonblock() and fd_set_cloexec()

2022-04-26 10:59:48 +02:00

sock.c

MINOR: connection: get rid of the CO_FL_ADDR_*_SET flags

2022-05-02 17:47:46 +02:00

ssl_ckch.c

BUG/MINOR: ssl: Do not look for key in extra files if already in pem

2022-06-22 10:45:47 +02:00

ssl_crtlist.c

BUG/MEDIUM: ssl/cli: crash when crt inserted into a crt-list

2022-06-20 17:27:49 +02:00

ssl_sample.c

CLEANUP: check: rename all occurrences of stconn "cs" to "sc"

2022-05-27 19:33:35 +02:00

ssl_sock.c

BUG/MEDIUM: ssl/fd: unexpected fd close using async engine

2022-07-01 17:41:40 +02:00

ssl_utils.c

CLEANUP: Add missing header to ssl_utils.c

2022-05-17 11:40:33 +02:00

stats.c

BUG/MINOR: cli/stats: add missing trailing LF after "show info json"

2022-06-10 15:12:21 +02:00

stconn.c

CLEANUP: stconn: Don't expect to have no sedesc on detach

2022-06-17 13:25:02 +02:00

stick_table.c

CLEANUP: applet: rename appctx_cs() to appctx_sc()

2022-05-27 19:33:35 +02:00

stream.c

CLEANUP: task: remove thread_mask from the struct task

2022-07-01 19:15:14 +02:00

task.c

MINOR: thread: only use atomic ops to touch the flags

2022-07-01 19:15:14 +02:00

tcp_act.c

REORG: rename cs_utils.h to sc_strm.h

2022-05-27 19:33:35 +02:00

tcp_rules.c

BUG/MINOR: tcp-rules: Make action call final on read error and delay expiration

2022-06-13 08:04:10 +02:00

tcp_sample.c

CLEANUP: check: rename all occurrences of stconn "cs" to "sc"

2022-05-27 19:33:35 +02:00

tcpcheck.c

BUG/MINOR: http-check: Preserve headers if not redefined by an implicit rule

2022-07-06 09:35:13 +02:00

thread.c

MAJOR: threads: change thread_isolate to support inter-group synchronization

2022-07-01 19:15:15 +02:00

time.c

REORG: time: move time-keeping code and variables to clock.c

2021-10-08 17:22:26 +02:00

tools.c

MINOR: intops: add a function to return a valid bit position from a mask

2022-06-21 20:29:57 +02:00

trace.c

BUG/MINOR: trace: Test server existence for health-checks to get proxy

2022-06-08 15:28:38 +02:00

uri_auth.c

…

uri_normalizer.c

…

vars.c

CLEANUP: vars: move the per-process variables initialization to vars.c

2022-02-23 17:11:33 +01:00

version.c

…

wdt.c

MINOR: wdt: do not rely on threads_to_dump anymore

2022-07-01 19:26:35 +02:00

xprt_handshake.c

CLEANUP: pool/tree-wide: remove suffix "_pool" from certain pool names

2022-06-23 11:49:09 +02:00

xprt_quic.c

MINOR: quic: Improvements for the datagrams receipt

2022-06-30 14:34:27 +02:00