mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-09-22 06:11:32 +02:00
f2dda52e78
The CLI's payload parser is over-complicated and as such contains more bugs than needed. One of them is that it uses strstr() to find the ending tag, ignoring spaces before it, while the argument locator creates a new arg on each space, without checking if the end of the word appears past the previously found end. This results in "<<" being considered as the start of a new argument if preceeded by more than one space, and the payload being damaged with a \0 inserted at the first space or tab. Let's make an easily backportable fix for now. This fix makes sure that the trailing zero from the first line is properly kept after '<<' and that the end tag is looked for only as an isolated argument and nothing else. This also gets rid of the unsuitable strstr() call and now makes sure that strcspn() will not return elements that are found in the payload. For the long term the loop must be rewritten to get rid of those unsuitable strcspn() and strstr() calls which work past each other, and the cli_parse_request() function should be split into a tokenizer and an executor that are used from the caller instead of letting the caller play games with what it finds there. This should be backported wherever CLI payload is supported, i.e. 2.0+.
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)