mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2026-01-14 21:31:00 +01:00
ecb40b2c38
The "first req" rule consists in not delivering a connection's first request to a connection that's not known for being safe so that we don't deliver a broken page to a client if the server didn't intend to keep it alive. That's what's used by "http-reuse safe" particularly. But the reason this rule was created was precisely because haproxy was not able to re-emit the request to the server in case of connection breakage, which is precisely what l7 retries later brought. As such, there's no reason for enforcing this rule when l7 retries are properly enabled because such a blank page will trigger a retry and will not be delivered to the client. This patch simply checks that the l7 retries are enabled for the 3 cases that can be triggered on a dead or dying connection (failure, empty, and timeout), and if all 3 are enabled, then regular idle connections can be reused. This could almost be marked as a bug fix because a lot of users relying on l7 retries do not necessarily think about using http-reuse always due to the recommendation against it in the doc, while the protection that the safe mode offers is never used in that mode, and it forces the http client not to reuse existing persistent connections since it never sets the "not first" flag. It could also be decided that the protection is not used either when the origin is an applet, as in this case this is internal code that we can decide to let handle the retry by itself (all info are still present). But at least the httpclient will be happy with this alone. It would make sense to backport this at least to 2.6 in order to let the httpclient reuse connections, maybe to older releases if some users report low reuse counts.
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)