mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2026-01-30 06:22:00 +01:00
ec361bbd84
If a parsing error is detected and the corresponding HTX flag is set (HTX_FL_PARSING_ERROR), we must be sure to always report it to the app layer. It is especially important when the error occurs during the response parsing, on the server side. In this case, the RX buffer contains an empty HTX message to carry the flag. And it remains in this state till the info is reported to the app layer. This must be done otherwise, on the conn-stream, the CS_FL_ERR_PENDING flag cannot be switched to CS_FL_ERROR and the CS_FL_WANT_ROOM flag is always set when h2_rcv_buf() is called. The result is a ping-pong loop between the mux and the stream. Note that this patch fixes a bug. But it also reveals a design issue. The error must not be reported at the HTX level. The error is already carried by the conn-stream. There is no reason to duplicate it. In addition, it is errorprone to have an empty HTX message only to report the error to the app layer. This patch should fix the issue #1561. It must be backported as far as 2.0 but the bug only affects HAProxy >= 2.4.
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)