mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-08-05 22:56:57 +02:00
e1465c1e46
Some regtests involve multiple requests from multiple clients, which can be dispatched as multiple requests to a server. It turns out that the idle connection sharing works so well that very quickly few connections are used, and regularly some of the remaining idle server connections time out at the moment they were going to be reused, causing those random "HTTP header incomplete" traces in the logs that make them fail often. In the end this is only an artefact of the test environment. And indeed, some tests like normalize-uri which perform a lot of reuse fail very often, about 20-30% of the times in the CI, and 100% of the time in local when running 1000 tests in a row. Others like ubase64, sample_fetches or vary_* fail less often but still a lot in tests. This patch addresses this by adding "tune.idle-pool.shared off" to all tests which have at least twice as many requests as clients. It proves very effective as no single error happens on normalize-uri anymore after 10000 tests. Also 100 full runs of all tests yield no error anymore. One test is tricky, http_abortonclose, it used to fail ~10 times per 1000 runs and with this workaround still fails once every 1000 runs. But the test is complex and there's a warning in it mentioning a possible issue when run in parallel due to a port reuse.
121 lines
2.9 KiB
Plaintext
121 lines
2.9 KiB
Plaintext
varnishtest "A test for the abortonclose option (H1 only)"
|
|
feature ignore_unknown_macro
|
|
|
|
# NOTE : This test may fail if too many vtest are running in parallel because
|
|
# the port reserved for closed s1 server may be reused by another vtest
|
|
|
|
#REQUIRE_VERSION=2.3
|
|
#REGTEST_TYPE=slow
|
|
|
|
# b1 : Don't send /c4 before /c3 was received by s2 server
|
|
# b2 : Don't finish c2 before c1 and c3 before c4 (from syslog POV)
|
|
# b3 : finish c3 before s2
|
|
|
|
barrier b1 cond 2 -cyclic
|
|
barrier b2 cond 2 -cyclic
|
|
barrier b3 cond 2 -cyclic
|
|
|
|
server s1 {
|
|
} -start
|
|
server s1 -break
|
|
|
|
server s2 {
|
|
rxreq
|
|
|
|
# unlock c4
|
|
barrier b1 sync
|
|
|
|
# wait end of c3
|
|
barrier b3 sync
|
|
|
|
expect_close
|
|
} -start
|
|
|
|
syslog S -level info {
|
|
recv
|
|
expect ~ "[^:\\[ ]*\\[[0-9]*\\]: .* .* fe1 be1/srv1 [0-9]*/[0-9]*/-1/-1/[0-9]* 503 .* - - SC-- .* .* \"GET /c1 HTTP/1\\.1\""
|
|
barrier b2 sync
|
|
recv
|
|
expect ~ "[^:\\[ ]*\\[[0-9]*\\]: .* .* fe1 be1/srv1 [0-9]*/[0-9]*/-1/-1/[0-9]* 503 .* - - CC-- .* .* \"GET /c2 HTTP/1\\.1\""
|
|
|
|
recv
|
|
expect ~ "[^:\\[ ]*\\[[0-9]*\\]: .* .* fe2 be2/<NOSRV> [0-9]*/[0-9]*/-1/-1/[0-9]* 503 .* - - CQ-- .* .* \"GET /c4 HTTP/1\\.1\""
|
|
barrier b2 sync
|
|
recv
|
|
expect ~ "[^:\\[ ]*\\[[0-9]*\\]: .* .* fe2 be2/srv1 [0-9]*/[0-9]*/[0-9]*/-1/[0-9]* 400 .* - - CH-- .* .* \"GET /c3 HTTP/1\\.1\""
|
|
} -start
|
|
|
|
haproxy h1 -conf {
|
|
global
|
|
# WT: limit false-positives causing "HTTP header incomplete" due to
|
|
# idle server connections being randomly used and randomly expiring
|
|
# under us.
|
|
tune.idle-pool.shared off
|
|
|
|
defaults
|
|
mode http
|
|
${no-htx} option http-use-htx
|
|
option abortonclose
|
|
retries 3
|
|
timeout client 10s
|
|
timeout server 10s
|
|
timeout connect 100ms
|
|
timeout queue 5s
|
|
|
|
frontend fe1
|
|
option httplog
|
|
log ${S_addr}:${S_port} local0 debug err
|
|
bind "fd@${fe1}"
|
|
use_backend be1
|
|
|
|
frontend fe2
|
|
option httplog
|
|
log ${S_addr}:${S_port} local0 debug err
|
|
bind "fd@${fe2}"
|
|
use_backend be2
|
|
|
|
backend be1
|
|
server srv1 ${s1_addr}:${s1_port}
|
|
|
|
backend be2
|
|
server srv1 ${s2_addr}:${s2_port} maxconn 1
|
|
} -start
|
|
|
|
# No server, wait all connection retries : SC--
|
|
client c1 -connect ${h1_fe1_sock} {
|
|
txreq -url /c1
|
|
expect_close
|
|
} -run
|
|
|
|
# Wait c1 log entry
|
|
barrier b2 sync
|
|
|
|
# No server, abort during connections retries : CC--
|
|
client c2 -connect ${h1_fe1_sock} {
|
|
txreq -url /c2
|
|
} -run
|
|
|
|
# server with maxconn=1, abort waiting the server reply : CH--
|
|
client c3 -connect ${h1_fe2_sock} {
|
|
txreq -url /c3
|
|
|
|
# Wait c4 log entry
|
|
barrier b2 sync
|
|
} -start
|
|
|
|
# server with maxconn=1, abort waiting in the queue (c3 still attached) : CQ--
|
|
client c4 -connect ${h1_fe2_sock} {
|
|
# Wait s2 receives c3 request
|
|
barrier b1 sync
|
|
|
|
txreq -url /c4
|
|
delay .2
|
|
} -run
|
|
|
|
client c3 -wait
|
|
|
|
# unlock s2
|
|
barrier b3 sync
|
|
|
|
syslog S -wait
|