mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-08-05 22:56:57 +02:00
e1465c1e46
Some regtests involve multiple requests from multiple clients, which can be dispatched as multiple requests to a server. It turns out that the idle connection sharing works so well that very quickly few connections are used, and regularly some of the remaining idle server connections time out at the moment they were going to be reused, causing those random "HTTP header incomplete" traces in the logs that make them fail often. In the end this is only an artefact of the test environment. And indeed, some tests like normalize-uri which perform a lot of reuse fail very often, about 20-30% of the times in the CI, and 100% of the time in local when running 1000 tests in a row. Others like ubase64, sample_fetches or vary_* fail less often but still a lot in tests. This patch addresses this by adding "tune.idle-pool.shared off" to all tests which have at least twice as many requests as clients. It proves very effective as no single error happens on normalize-uri anymore after 10000 tests. Also 100 full runs of all tests yield no error anymore. One test is tricky, http_abortonclose, it used to fail ~10 times per 1000 runs and with this workaround still fails once every 1000 runs. But the test is complex and there's a warning in it mentioning a possible issue when run in parallel due to a port reuse.
335 lines
11 KiB
Plaintext
335 lines
11 KiB
Plaintext
varnishtest "Check the Accept-Encoding processing implemented in the Vary mechanism"
|
|
|
|
#REQUIRE_VERSION=2.4
|
|
|
|
feature ignore_unknown_macro
|
|
|
|
server s1 {
|
|
# Response varying on "accept-encoding" with a gzip content-encoding
|
|
rxreq
|
|
expect req.url == "/accept-encoding"
|
|
txresp -hdr "Content-Encoding: gzip" \
|
|
-hdr "Vary: accept-encoding" \
|
|
-hdr "Cache-Control: max-age=5" \
|
|
-bodylen 45
|
|
|
|
# Response varying on "accept-encoding" with a deflate content-encoding
|
|
rxreq
|
|
expect req.url == "/accept-encoding"
|
|
txresp -hdr "Content-Encoding: deflate" \
|
|
-hdr "Vary: accept-encoding" \
|
|
-hdr "Cache-Control: max-age=5" \
|
|
-bodylen 55
|
|
|
|
|
|
# Response varying on "accept-encoding" with no content-encoding (identity)
|
|
rxreq
|
|
expect req.url == "/accept-encoding-identity"
|
|
txresp -hdr "Vary: accept-encoding" \
|
|
-hdr "Cache-Control: max-age=5" \
|
|
-bodylen 65
|
|
|
|
# Response varying on "accept-encoding" with refused identity encoding
|
|
rxreq
|
|
expect req.url == "/accept-encoding-identity"
|
|
txresp -hdr "Vary: accept-encoding" \
|
|
-hdr "Cache-Control: max-age=5" \
|
|
-hdr "Content-Encoding: deflate" \
|
|
-bodylen 75
|
|
|
|
|
|
rxreq
|
|
expect req.url == "/accept-encoding-star"
|
|
txresp -hdr "Vary: accept-encoding" \
|
|
-hdr "Cache-Control: max-age=5" \
|
|
-hdr "Content-Encoding: br" \
|
|
-bodylen 89
|
|
|
|
rxreq
|
|
expect req.url == "/accept-encoding-star"
|
|
txresp -hdr "Vary: accept-encoding" \
|
|
-hdr "Cache-Control: max-age=5" \
|
|
-hdr "Content-Encoding: deflate" \
|
|
-bodylen 99
|
|
|
|
|
|
rxreq
|
|
expect req.url == "/multiple-content-encoding"
|
|
txresp -hdr "Vary: accept-encoding" \
|
|
-hdr "Cache-Control: max-age=5" \
|
|
-hdr "Content-Encoding: deflate, gzip" \
|
|
-bodylen 109
|
|
|
|
rxreq
|
|
expect req.url == "/unknown-content-encoding"
|
|
txresp -hdr "Vary: accept-encoding" \
|
|
-hdr "Cache-Control: max-age=5" \
|
|
-hdr "Content-Encoding: unknown_encoding" \
|
|
-bodylen 119
|
|
|
|
rxreq
|
|
expect req.url == "/unknown-content-encoding"
|
|
txresp -hdr "Vary: accept-encoding" \
|
|
-hdr "Cache-Control: max-age=5" \
|
|
-hdr "Content-Encoding: unknown_encoding" \
|
|
-bodylen 119
|
|
|
|
|
|
rxreq
|
|
expect req.url == "/hash-collision"
|
|
txresp -hdr "Vary: accept-encoding" \
|
|
-hdr "Cache-Control: max-age=5" \
|
|
-hdr "Content-Encoding: br" \
|
|
-bodylen 129
|
|
|
|
rxreq
|
|
expect req.url == "/hash-collision"
|
|
txresp -hdr "Vary: accept-encoding" \
|
|
-hdr "Cache-Control: max-age=5" \
|
|
-hdr "Content-Encoding: gzip" \
|
|
-bodylen 139
|
|
} -start
|
|
|
|
|
|
haproxy h1 -conf {
|
|
global
|
|
# WT: limit false-positives causing "HTTP header incomplete" due to
|
|
# idle server connections being randomly used and randomly expiring
|
|
# under us.
|
|
tune.idle-pool.shared off
|
|
|
|
defaults
|
|
mode http
|
|
${no-htx} option http-use-htx
|
|
timeout connect 1s
|
|
timeout client 1s
|
|
timeout server 1s
|
|
|
|
frontend fe
|
|
bind "fd@${fe}"
|
|
default_backend test
|
|
|
|
backend test
|
|
http-request cache-use my_cache
|
|
server www ${s1_addr}:${s1_port}
|
|
http-response cache-store my_cache
|
|
http-response set-header X-Cache-Hit %[res.cache_hit]
|
|
|
|
cache my_cache
|
|
total-max-size 3
|
|
max-age 20
|
|
max-object-size 3072
|
|
process-vary on
|
|
} -start
|
|
|
|
|
|
client c1 -connect ${h1_fe_sock} {
|
|
#
|
|
# Accept-Encoding Vary
|
|
#
|
|
|
|
# First request
|
|
txreq -url "/accept-encoding" -hdr "Accept-Encoding: gzip"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "gzip"
|
|
expect resp.bodylen == 45
|
|
|
|
# Regular case
|
|
txreq -url "/accept-encoding" -hdr "Accept-Encoding: gzip"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "gzip"
|
|
expect resp.bodylen == 45
|
|
expect resp.http.X-Cache-Hit == 1
|
|
|
|
# Regular case with upper case encoding
|
|
txreq -url "/accept-encoding" -hdr "Accept-Encoding: GZIP"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "gzip"
|
|
expect resp.bodylen == 45
|
|
expect resp.http.X-Cache-Hit == 1
|
|
|
|
# Multiple accepted encodings (all standard)
|
|
txreq -url "/accept-encoding" -hdr "Accept-Encoding: deflate,gzip"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "gzip"
|
|
expect resp.bodylen == 45
|
|
expect resp.http.X-Cache-Hit == 1
|
|
|
|
# Multiple accept-encoding headers + non-standard accepted encodings
|
|
txreq -url "/accept-encoding" -hdr "Accept-Encoding: first_encoding,second_encoding" -hdr "Accept-Encoding: gzip"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "gzip"
|
|
expect resp.bodylen == 45
|
|
expect resp.http.X-Cache-Hit == 1
|
|
|
|
# Regular case with positive weight
|
|
txreq -url "/accept-encoding" -hdr "Accept-Encoding: gzip;q=0.8"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "gzip"
|
|
expect resp.bodylen == 45
|
|
expect resp.http.X-Cache-Hit == 1
|
|
|
|
# Regular case with positive weight and extra whitespaces
|
|
txreq -url "/accept-encoding" -hdr "Accept-Encoding: gzip ; q=0.8"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "gzip"
|
|
expect resp.bodylen == 45
|
|
expect resp.http.X-Cache-Hit == 1
|
|
|
|
# Regular case with null weight
|
|
txreq -url "/accept-encoding" -hdr "Accept-Encoding: deflate;q=0.8, gzip;q=0"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "deflate"
|
|
expect resp.bodylen == 55
|
|
expect resp.http.X-Cache-Hit == 0
|
|
|
|
|
|
#
|
|
# Identity tests
|
|
#
|
|
txreq -url "/accept-encoding-identity"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "<undef>"
|
|
expect resp.bodylen == 65
|
|
expect resp.http.X-Cache-Hit == 0
|
|
|
|
# Regular case
|
|
txreq -url "/accept-encoding-identity"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "<undef>"
|
|
expect resp.bodylen == 65
|
|
expect resp.http.X-Cache-Hit == 1
|
|
|
|
# Identity is allowed by default even if another encoding is specified
|
|
txreq -url "/accept-encoding-identity" -hdr "Accept-Encoding: gzip"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "<undef>"
|
|
expect resp.bodylen == 65
|
|
expect resp.http.X-Cache-Hit == 1
|
|
|
|
# Refused identity encoding (explicit null weight)
|
|
txreq -url "/accept-encoding-identity" -hdr "Accept-Encoding: deflate, identity;q=0"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "deflate"
|
|
expect resp.bodylen == 75
|
|
expect resp.http.X-Cache-Hit == 0
|
|
|
|
|
|
#
|
|
# Star tests
|
|
#
|
|
txreq -url "/accept-encoding-star" -hdr "Accept-Encoding: *"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "br"
|
|
expect resp.bodylen == 89
|
|
expect resp.http.X-Cache-Hit == 0
|
|
|
|
# Regular case
|
|
txreq -url "/accept-encoding-star" -hdr "Accept-Encoding: *"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "br"
|
|
expect resp.bodylen == 89
|
|
expect resp.http.X-Cache-Hit == 1
|
|
|
|
# Reject some encodings
|
|
txreq -url "/accept-encoding-star" -hdr "Accept-Encoding: gzip;q=0, deflate,*"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "br"
|
|
expect resp.bodylen == 89
|
|
expect resp.http.X-Cache-Hit == 1
|
|
|
|
# Weighted star
|
|
txreq -url "/accept-encoding-star" -hdr "Accept-Encoding: gzip;q=0, deflate,*;q=0.1"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "br"
|
|
expect resp.bodylen == 89
|
|
expect resp.http.X-Cache-Hit == 1
|
|
|
|
# Rejected identity
|
|
txreq -url "/accept-encoding-star" -hdr "Accept-Encoding: gzip;q=0, deflate,*;q=0.1,identity;q=0"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "br"
|
|
expect resp.bodylen == 89
|
|
expect resp.http.X-Cache-Hit == 1
|
|
|
|
# Rejected star and "br" not accepted
|
|
txreq -url "/accept-encoding-star" -hdr "Accept-Encoding: gzip;q=0, deflate,*;q=0"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "deflate"
|
|
expect resp.bodylen == 99
|
|
expect resp.http.X-Cache-Hit == 0
|
|
|
|
|
|
#
|
|
# Multiple content-encodings
|
|
#
|
|
txreq -url "/multiple-content-encoding" -hdr "Accept-Encoding: gzip;q=0.8, deflate"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "deflate, gzip"
|
|
expect resp.bodylen == 109
|
|
expect resp.http.X-Cache-Hit == 0
|
|
|
|
txreq -url "/multiple-content-encoding" -hdr "Accept-Encoding: deflate,gzip;q=0.7"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "deflate, gzip"
|
|
expect resp.bodylen == 109
|
|
expect resp.http.X-Cache-Hit == 1
|
|
|
|
|
|
#
|
|
# Unknown content-encoding
|
|
# The response should not be cached since it has an unknown content encoding
|
|
#
|
|
txreq -url "/unknown-content-encoding" -hdr "Accept-Encoding: gzip;q=0.8, deflate, first_encoding"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "unknown_encoding"
|
|
expect resp.bodylen == 119
|
|
expect resp.http.X-Cache-Hit == 0
|
|
|
|
txreq -url "/unknown-content-encoding" -hdr "Accept-Encoding: deflate,gzip;q=0.8, first_encoding"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "unknown_encoding"
|
|
expect resp.bodylen == 119
|
|
expect resp.http.X-Cache-Hit == 0
|
|
|
|
#
|
|
# Hash collision (https://github.com/haproxy/haproxy/issues/988)
|
|
#
|
|
# crc32(gzip) ^ crc32(br) ^ crc32(xxx) ^ crc32(jdcqiab) == crc32(gzip)
|
|
txreq -url "/hash-collision" -hdr "Accept-Encoding: br,gzip,xxx,jdcqiab"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "br"
|
|
expect resp.bodylen == 129
|
|
expect resp.http.X-Cache-Hit == 0
|
|
|
|
txreq -url "/hash-collision" -hdr "Accept-Encoding: gzip"
|
|
rxresp
|
|
expect resp.status == 200
|
|
expect resp.http.content-encoding == "gzip"
|
|
expect resp.bodylen == 139
|
|
expect resp.http.X-Cache-Hit == 0
|
|
} -run
|