mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-09-21 22:01:31 +02:00
df6c5a8ffa
The copy_argv() function, which is used to copy and remove some of the arguments of the command line in order to re-exec() the master process, is poorly implemented. The function tries to remove the -x and the -sf/-st options but without taking into account that some of the options could take a parameter starting with a dash. In issue #644, haproxy starts with "-L -xfoo" which is perfectly correct. However, the re-exec is done without "-xfoo" because the master tries to remove the "-x" option. Indeed, the copy_argv() function does not know how much arguments an option can have, and just assume that everything starting with a dash is an option. So haproxy is exec() with "-L" but without a parameter, which is wrong and leads to the exit of the master, with usage(). To fix this issue, copy_argv() must know how much parameters an option takes, and copy or skip the parameters correctly. This fix is a first step but it should evolve to a cleaner way of declaring the options to avoid deduplication of the parsing code, so we avoid new bugs. Should be backported with care as far as 1.8, by removing the options that does not exists in the previous versions.
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)