mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-09-20 13:21:29 +02:00
cc2e94a948
Christian reported in GH #2556 that since 3.0-dev double spaces may be found in log messages on some cases where it was not the case before. As we were able to easily reproduce, a quick bisect led us to c6a7138 ("MINOR: log: simplify last_isspace in sess_build_logline()"). While it is true that all switch cases set the last_isspace variable to 0, there was a subtelty for some fields such as '%hr', '%hrl', '%hs' or '%hsl' and I overlooked it. Indeed, for '%hr', last_isspace was only set to 0 if data was emitted, else the assignment didn't occur. But with c6a7138, last_isspace is always set to 0 as long as the current node type is not a separator. Because of that, if no data is emitted for the current node value, and a space was already emitted prior to the current node, then an extra space could be emitted after the node, resulting in two spaces being emitted. Note that while c6a7138 introduces a slight behavior regression regarding last_isspace logic with the specific fields mentionned above, this behavior could already be triggered with a failing or empty logformat node sample expression. Consider this logformat expression: log-format "%{-M}o | %[str()] |" str() will not print anything, and since we disabled mandatory option with '-M', nothing gets printed for the node sample expression. As a result, we have the following output: "| |" Instead of (when mandatory option is enabled): "| - |" Thus in order to stick to the historical behavior, systematically set last_isspace to 0 for EXPR nodes, and only set last_isspace to 0 when data was written for TAG nodes. This way, '%hr', '%hrl', '%hs' or '%hsl' should behave as before. No backport needed.
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)