Frédéric Lécaille af25a69c8b MEDIUM: quic: Remove qc_conn_finalize() from the ClientHello TLS callbacks ... This is a bad idea to make the TLS ClientHello callback call qc_conn_finalize(). If this latter fails, this would generate a TLS alert and make the connection send packet whereas it is not functional. But qc_conn_finalize() job was to install the transport parameters sent by the QUIC listener. This installation cannot be done at any time. This must be done after having possibly negotiated the QUIC version and before sending the first Handshake packets. It seems the better moment to do that in when the Handshake TX secrets are derived. This has been found inspecting the ngtcp2 code. Calling SSL_set_quic_transport_params() too late would make the ServerHello to be sent without the transport parameters. The code for the connection update which was done from qc_conn_finalize() has been moved to quic_transport_params_store(). So, this update is done as soon as possible. Add QUIC_FL_CONN_TX_TP_RECEIVED to flag the connection as having received the peer transport parameters. Indeed this is required when the ClientHello message is splitted between packets. Add QUIC_FL_CONN_FINALIZED to protect the connection from calling qc_conn_finalize() more than one time. This latter is called only when the connection has received the transport parameters and after returning from SSL_do_hanshake() which is the function which trigger the TLS ClientHello callback call. Remove the calls to qc_conn_finalize() from from the TLS ClientHello callbacks. Must be backported to 2.6. and 2.7.		2023-02-03 17:55:55 +01:00
..
haproxy	MEDIUM: quic: Remove qc_conn_finalize() from the ClientHello TLS callbacks	2023-02-03 17:55:55 +01:00
import	CLEANUP: assorted typo fixes in the code and comments	2022-11-30 14:02:36 +01:00
make	BUILD: makefile: only consider settings from enabled options	2022-12-23 17:01:55 +01:00