mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2026-03-03 06:01:09 +01:00
9578524091
hlua_filter_new() handles memory allocation errors by jumping to the "end:" cleanup label in case of errors. Such errors may happen when the system is heavily loaded for instance. In hlua_filter_new(), we try to allocate two hlua contexts in a row before checking if one of them failed (in which case we jump to the cleanup part of the function), and only then we initialize them both. If a memory allocation failure happens for only one out of the two flt_ctx->hlua[] contexts pair, we still jump to the cleanup part. It means that the hlua context that was successfully allocated and wasn't initialized yet will be passed to hlua_ctx_destroy(), resulting in invalid reads in the cleanup function, which may ultimately cause the process to crash. To fix the issue: we make sure flt_ctx hlua contexts are initialized right after they are allocated, that is before any error handling condition that may force the cleanup. This bug was discovered when trying to reproduce GH #2467 with haproxy started with "-dMfail" argument. It should be backported up to 2.6.
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)