90b2154d93
When an idle connection is private or considered private, session_add_conn() is called to add it to the list of connections owned by the session. But in case of allocation failure, the session is not set, which results in a long list of possible situations that are all corner cases which are difficult to test (and debug). This commit relies on the fact that it is already permitted to have conn->owner pointing to a session even if the connection couldn't be added to the session's list, as this was already the case in conn_backend_get() when dealing with HOL_RISK. Also as seen in commit 3aab17bd566 added in 2.4, it is already possible to have conn->owner set with the connection not being in a list, and only the list element is checked for this. This commit modifies session_add_conn() to always set conn->onwer, even if the list element couldn't be allocated. This way it's possible to always refer to conn->owner to find the session owning a private conn even in case of failure to allocate an entry. This requires to change the checks on conn->owner to a check of the list element to see if the connection belongs to a session, the pre-assignment of sess to conn->owner in conn_backend_get() is no longer needed, same for the pre-assignment in http_wait_for_response(), and that's all. The H1 mux remained unchanged because since it cannot multiplex, in case it fails to allocate a pconn, it instantly kills the connection.
HAProxy
HAProxy is a free, very fast and reliable reverse-proxy offering high availability, load balancing, and proxying for TCP and HTTP-based applications.
Installation
The INSTALL file describes how to build HAProxy. A list of packages is also available on the wiki.
Getting help
The discourse and the mailing-list are available for questions or configuration assistance. You can also use the slack or IRC channel. Please don't use the issue tracker for these.
The issue tracker is only for bug reports or feature requests.
Documentation
The HAProxy documentation has been split into a number of different files for ease of use. It is available in text format as well as HTML. The wiki is also meant to replace the old architecture guide.
Please refer to the following files depending on what you're looking for:
- INSTALL for instructions on how to build and install HAProxy
- BRANCHES to understand the project's life cycle and what version to use
- LICENSE for the project's license
- CONTRIBUTING for the process to follow to submit contributions
The more detailed documentation is located into the doc/ directory:
- doc/intro.txt for a quick introduction on HAProxy
- doc/configuration.txt for the configuration's reference manual
- doc/lua.txt for the Lua's reference manual
- doc/SPOE.txt for how to use the SPOE engine
- doc/network-namespaces.txt for how to use network namespaces under Linux
- doc/management.txt for the management guide
- doc/regression-testing.txt for how to use the regression testing suite
- doc/peers.txt for the peers protocol reference
- doc/coding-style.txt for how to adopt HAProxy's coding style
- doc/internals for developer-specific documentation (not all up to date)
License
HAProxy is licensed under GPL 2 or any later version, the headers under LGPL 2.1. See the LICENSE file for a more detailed explanation.