mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-10-09 06:31:34 +02:00
8e21bb9e52
This flag was very problematic because it was composite in that both changes to the pipe or to the buffer had to cause this flag to be updated, which is not always simple (eg: there may not even be a channel attached to a buffer at all). There were not that many users of this flags, mostly setters. So the flag got replaced with a macro which reports whether the channel is empty or not, by checking both the pipe and the buffer. One part of the change is sensible : the flag was also part of BF_MASK_STATIC, which is used by process_session() to rescan all analysers in case the flag's status changes. At first glance, none of the analysers seems to change its mind base on this flag when it is subject to change, so it seems fine not to add variation checks here. Otherwise it's possible that checking the buffer's output size is more useful than checking the flag's replacement.