mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-09-22 06:11:32 +02:00
82cd028d71
The code dealing with zombie proxies in soft_stop() is bogus, it uses close() instead of fd_delete(), leaving a live entry in the fdtab with a dangling pointer to a free memory location. The FD might be reassigned for an outgoing connection for the time it takes the proxy to completely stop, or could be dumped on the CLI's "show fd" command. In addition, the listener's FD was not even reset, leaving doubts about whether or not it will happen again in deinit(). And in deinit(), the loop in charge of closing zombie FDs is particularly unsafe because it closes the fd then calls unbind_listener() then delete_listener() hoping none of them will touch it again. Since it requires some mental efforts to figure what's done there, let's correctly reset the fd here as well and close it using fd_delete() to eliminate any remaining doubts. It's uncertain whether this should be backported. Zombie proxies are rare and the situations capable of triggering such issues are not trivial to setup. However it's easy to imagine how things could go wrong if backported too far. Better wait for any matching report if at all (this code has been there since 1.8 without anobody noticing).
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)