mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-10-07 13:41:49 +02:00
80a92c02f4
Currently, "balance url_param check_post" randomly works. If the client sends chunked data and there's another chunk after the one containing the data, http_request_forward_body() will advance msg->sov and move the start of data to the beginning of the last chunk, and get_server_ph_post() will not find the data. In order to avoid this, we add an HTTP_MSGF_WAIT_CONN flag whose goal is to prevent the forwarding code from parsing until the connection is confirmed, so that we're certain not to fail on a redispatch. Note that we need to force channel_auto_connect() since the output buffer is empty and a previous analyser might have stopped auto-connect. The flag is currently set whenever some L7 POST analysis is needed for a connect() so that it correctly addresses all corner cases involving a possible rewind of the buffer, waiting for a better fix. Note that this has been broken for a very long time. Even all 1.4 versions seem broken but differently, with ->sov pointing to the end of the arguments. So the fix should be considered for backporting to all stable releases, possibly including 1.3 which works differently.