mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-08-06 07:07:04 +02:00
7a12e2d369
httpclient used to register a global post-check function to iterate over all known proxies and post-initialize httpclient related ones (mainly for logs initialization). But we currently have an issue: post_sink_resolve() function which is also registered using REGISTER_POST_CHECK() macro conflicts with httpclient_postcheck() function. This is because post_sink_resolve() relies on proxy->logsrvs to be correctly initialized already, and httpclient_postcheck() may create and insert new logsrvs entries to existing proxies when executed. So depending on which function runs first, we could run into trouble. Hopefully, to this day, everything works "by accident" due to http_client.c file being loaded before sink.c file when compiling source code. But as soon as we would move one of the two functions to other files, or if we rename files or make changes to the Makefile build recipe, we could break this at any time. To prevent post_sink_resolve() from randomly failing in the future, we now make httpclient postcheck rely on per-proxy post-checks by slightly modifying httpclient_postcheck() function so that it can be registered using REGISTER_POST_PROXY_CHECK() macro. As per-proxy post-check functions are executed right after config parsing for each known proxy (vs global post-check which are executed a bit later in the init process), we can be certain that functions registered using global post-check macro, ie: post_sink_resolve(), will always be executed after httpclient postcheck, effectively resolving the ordering conflict. This should normally not cause visible behavior changes, and while it could be considered as a bug, it's probably not worth backporting it since the only way to trigger the issue is through code refactors, unless we want to backport it to ease code maintenance of course, in which case it should easily apply for >= 2.7. |
||
|---|---|---|
| .github | ||
| addons | ||
| admin | ||
| dev | ||
| doc | ||
| examples | ||
| include | ||
| reg-tests | ||
| scripts | ||
| src | ||
| tests | ||
| .cirrus.yml | ||
| .gitattributes | ||
| .gitignore | ||
| .mailmap | ||
| .travis.yml | ||
| BRANCHES | ||
| BSDmakefile | ||
| CHANGELOG | ||
| CONTRIBUTING | ||
| INSTALL | ||
| LICENSE | ||
| MAINTAINERS | ||
| Makefile | ||
| README | ||
| SUBVERS | ||
| VERDATE | ||
| VERSION | ||
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)