mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-09-24 15:21:29 +02:00
77ac6f5667
This bug was revealed by key_update QUIC tracker test. During this test, after the handshake has succeeded, the client sends a 1-RTT packet containing only a PING frame. On our side, we do not acknowledge it, because we have no ack-eliciting packet to send. This is not correct. We must acknowledge all the ack-eliciting packets unconditionally. But we must not send too much ACK frames: every two packets since we have sent an ACK frame. This is the test (nb_aepkts_since_last_ack >= QUIC_MAX_RX_AEPKTS_SINCE_LAST_ACK) which ensure this is the case. But this condition must be checked at the very last time, when we are building a packet and when an acknowledgment is required. This is not to qc_may_build_pkt() to do that. This boolean function decides if we have packets to send. It must return "true" if there is no more ack-eliciting packets to send and if an acknowledgement is required. We must also add a "force_ack" parameter to qc_build_pkt() to force the acknowledments during the handshakes (for each packet). If not, they will be sent every two packets. This parameter must be passed to qc_do_build_pkt() and be checked alongside the others conditions when building a packet to decide to add an ACK frame or not to this packet. Must be backported to 2.6.
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)