William Lallemand
5b19d95850
BUG/MEDIUM: mworker/listener: ambiguous use of RX_F_INHERITED with shards
...
The RX_F_INHERITED flag was ambiguous, as it was used to mark both
listeners inherited from the parent process and listeners duplicated
from another local receiver. This could lead to incorrect behavior
concerning socket unbinding and suspension.
This commit refactors the handling of inherited listeners by splitting
the RX_F_INHERITED flag into two more specific flags:
- RX_F_INHERITED_FD: Indicates a listener inherited from the parent
process via its file descriptor. These listeners should not be unbound
by the master.
- RX_F_INHERITED_SOCK: Indicates a listener that shares a socket with
another one, either by being inherited from the parent or by being
duplicated from another local listener. These listeners should not be
suspended or resumed individually.
Previously, the sharding code was unconditionally using RX_F_INHERITED
when duplicating a file descriptor. In HAProxy versions prior to 3.1,
this led to a file descriptor leak for duplicated unix stats sockets in
the master process. This would eventually cause the master to crash with
a BUG_ON in fd_insert() once the file descriptor limit was reached.
This must be backported as far as 3.0. Branches earlier than 3.0 are
affected but would need a different patch as the logic is different.
2025-12-11 18:09:47 +01:00
..
2023-08-01 10:49:06 +02:00
2025-01-27 11:11:43 +01:00
2025-11-13 15:18:12 +01:00
2025-11-06 11:56:27 +01:00
2025-06-24 10:55:55 +02:00
2024-09-30 16:55:53 +02:00
2025-12-09 17:40:58 +01:00
2024-11-21 19:58:06 +01:00
2025-08-25 11:11:05 +02:00
2025-11-06 15:01:29 +01:00
2024-10-18 14:30:24 +02:00
2025-04-07 09:38:22 +02:00
2025-04-17 17:38:23 +02:00
2025-11-14 10:44:05 +01:00
2024-10-12 16:29:15 +02:00
2024-10-18 18:42:47 +02:00
2025-12-09 17:14:58 +01:00
2025-11-14 11:01:45 +01:00
2021-09-15 11:07:18 +02:00
2025-04-12 01:29:27 +02:00
2025-11-06 15:01:29 +01:00
2025-11-06 15:01:29 +01:00
2025-04-03 17:19:07 +02:00
2024-07-12 15:27:04 +02:00
2022-08-17 10:45:22 +02:00
2025-10-27 16:57:07 +01:00
2024-10-24 11:32:20 +02:00
2025-08-07 22:27:09 +02:00
2025-08-06 19:19:27 +02:00
2025-12-09 17:05:52 +01:00
2025-02-22 11:32:40 +01:00
2023-04-07 00:46:59 +02:00
2025-12-09 17:14:58 +01:00
2025-11-14 16:06:34 +01:00
2025-11-06 15:01:29 +01:00
2025-09-18 16:49:51 +02:00
2025-03-31 16:21:37 +02:00
2025-07-17 19:07:58 +02:00
2023-07-20 11:01:09 +02:00
2025-03-31 16:21:37 +02:00
2025-04-17 16:25:47 +02:00
2025-09-03 15:59:22 +02:00
2024-03-05 11:50:34 +01:00
2022-03-04 08:58:32 +01:00
2022-03-04 08:58:32 +01:00
2024-03-25 17:34:19 +00:00
2024-03-25 17:34:19 +00:00
2025-04-29 21:20:54 +02:00
2024-05-10 17:18:13 +02:00
2024-05-15 19:37:12 +02:00
2025-10-30 10:37:30 +01:00
2023-05-11 12:02:21 +02:00
2024-11-29 07:22:18 +01:00
2024-11-07 11:35:55 +01:00
2024-09-03 17:49:21 +02:00
2025-12-09 17:14:58 +01:00
2025-06-10 15:10:56 +02:00
2024-10-22 20:13:00 +02:00
2025-10-24 09:35:29 +02:00
2025-11-24 14:10:13 +01:00
2023-10-26 15:18:48 +02:00
2025-11-20 08:44:52 +01:00
2025-10-29 10:54:17 +01:00
2025-09-16 09:23:46 +02:00
2025-09-16 09:23:46 +02:00
2025-07-10 10:29:49 +02:00
2025-04-22 16:14:47 +02:00
2023-08-08 19:10:54 +02:00
2022-05-30 09:59:26 +02:00
2022-05-30 09:59:26 +02:00
2024-05-16 10:31:17 +02:00
2024-11-29 07:22:32 +01:00
2025-06-30 16:47:59 +02:00
2025-04-30 17:00:27 +02:00
2021-11-18 10:50:58 +01:00
2025-04-02 11:12:20 +02:00
2023-01-13 11:22:13 +01:00
2025-07-09 16:27:24 +02:00
2024-03-05 11:50:34 +01:00
2023-01-27 15:18:59 +01:00
2023-01-27 15:18:59 +01:00
2024-04-04 19:10:01 +02:00
2023-01-27 15:18:59 +01:00
2023-05-11 15:37:04 +02:00
2024-11-19 15:29:40 +01:00
2025-05-12 18:02:47 +02:00
2025-12-09 17:14:58 +01:00
2025-10-08 11:10:42 +02:00
2025-03-03 12:43:32 +01:00
2025-08-07 22:27:14 +02:00
2025-10-20 15:04:41 +02:00
2024-04-24 15:54:55 +02:00
2025-09-11 14:31:32 +02:00
2025-10-13 10:38:52 +02:00
2025-10-13 10:38:52 +02:00
2021-10-07 01:41:14 +02:00
2021-10-07 01:41:14 +02:00
2021-10-07 01:41:14 +02:00
2025-04-17 17:38:23 +02:00
2024-03-29 17:08:37 +01:00
2024-03-29 17:08:37 +01:00
2024-12-25 12:33:06 +01:00
2024-11-21 19:55:21 +01:00
2024-12-10 16:04:11 +01:00
2025-08-05 13:06:46 +02:00
2025-12-09 17:14:58 +01:00
2025-12-09 17:40:58 +01:00
2025-09-15 10:29:02 +02:00
2025-04-23 15:32:46 +02:00
2025-06-24 10:55:58 +02:00
2025-06-27 16:41:18 +02:00
2024-08-30 14:58:59 +02:00
2025-02-03 07:49:50 +01:00
2025-01-31 10:41:49 +01:00
2025-10-30 18:16:54 +01:00
2025-11-19 16:02:22 +01:00
2025-06-18 17:25:27 +02:00
2025-05-13 19:51:40 +02:00
2025-06-25 16:11:34 +02:00
2025-06-25 16:11:34 +02:00
2021-10-07 01:41:14 +02:00
2025-10-22 15:04:06 +02:00
2025-10-22 15:04:06 +02:00
2025-10-22 11:11:20 +02:00
2025-10-22 11:11:20 +02:00
2022-11-29 15:14:39 +01:00
2024-04-16 07:37:28 +02:00
2024-07-25 15:39:39 +02:00
2024-07-25 15:39:39 +02:00
2025-11-13 14:04:31 +01:00
2025-12-09 17:14:58 +01:00
2025-07-05 00:12:45 +02:00
2024-05-03 09:01:36 +02:00
2025-07-25 18:24:17 +02:00
2025-10-13 19:22:31 +02:00
2025-12-09 17:40:58 +01:00
2025-09-08 16:04:40 +02:00
2025-04-29 15:19:32 +02:00
2023-11-23 17:38:58 +01:00
2024-07-11 15:14:06 +02:00
2024-03-05 11:50:34 +01:00
2023-04-23 09:46:15 +02:00
2024-03-05 11:50:34 +01:00
2024-04-16 07:37:28 +02:00
2024-10-29 12:14:50 +01:00
2024-08-30 18:53:49 +02:00
2025-12-09 17:14:58 +01:00
2025-10-08 10:29:41 +02:00
2025-03-07 12:06:26 +01:00
2024-08-07 15:40:52 +02:00
2024-05-16 10:31:17 +02:00
2025-06-16 18:11:09 +02:00
2024-05-16 10:31:17 +02:00
2024-03-05 11:50:34 +01:00
2022-03-04 08:58:32 +01:00
2024-03-05 11:50:34 +01:00
2025-01-28 12:49:41 +01:00
2024-03-05 11:50:34 +01:00
2024-03-05 11:50:34 +01:00
2024-12-13 14:42:43 +01:00
2024-04-02 18:47:19 +02:00
2025-12-01 15:05:41 +01:00
2025-12-01 15:05:41 +01:00
2025-11-25 14:30:18 +01:00
2025-11-25 14:30:18 +01:00
2023-07-27 10:51:03 +02:00
2025-11-20 08:10:58 +01:00
2025-12-08 15:22:00 +01:00
2025-02-12 11:51:09 +01:00
2024-01-31 16:28:54 +01:00
2024-01-31 16:28:54 +01:00
2025-11-13 14:04:31 +01:00
2025-08-28 08:19:34 +02:00
2024-02-14 11:32:29 +01:00
2024-11-20 17:34:22 +01:00
2023-11-23 16:23:14 +01:00
2025-09-11 10:11:12 +02:00
2025-04-02 11:12:20 +02:00
2025-01-23 17:40:48 +01:00
2024-08-07 10:57:10 +02:00
2025-06-26 09:48:00 +02:00
2024-07-25 15:39:39 +02:00
2025-10-22 15:24:02 +02:00
2025-06-11 18:37:34 +02:00
2024-07-25 15:39:39 +02:00
2025-11-19 16:02:22 +01:00
2025-12-08 10:40:59 +01:00
2025-11-13 14:04:31 +01:00
2023-11-09 16:23:52 +01:00
2022-05-30 09:59:26 +02:00
2025-05-13 15:44:22 +02:00
2024-10-04 17:56:45 +02:00
2025-10-22 15:04:41 +02:00
2025-06-26 09:48:00 +02:00
2024-08-30 17:04:09 +02:00
2025-11-13 14:04:31 +01:00
2025-11-13 14:04:31 +01:00
2025-11-13 14:04:31 +01:00
2024-08-07 15:40:52 +02:00
2025-10-23 16:49:20 +02:00
2025-10-23 15:06:01 +02:00
2025-08-06 19:19:11 +02:00
2025-05-21 14:44:27 +02:00
2025-05-13 15:41:41 +02:00
2025-05-21 14:17:41 +02:00
2025-12-11 18:09:47 +01:00
2021-08-28 12:49:58 +02:00
2025-10-13 16:56:43 +02:00
2025-09-16 09:23:46 +02:00
2025-04-24 17:52:28 +02:00
2025-12-09 17:14:58 +01:00
2025-04-08 14:36:35 +02:00
2023-07-03 16:32:01 +02:00
2024-02-20 15:18:39 +01:00
2025-08-25 11:11:05 +02:00
2025-12-09 17:14:58 +01:00
2025-11-06 19:57:44 +01:00
2025-07-25 18:24:23 +02:00
2025-08-28 15:08:35 +02:00
2023-11-23 16:23:14 +01:00
2024-04-24 10:25:38 +02:00
2022-11-24 08:32:27 +01:00
2021-09-15 11:07:18 +02:00
2025-02-21 11:22:35 +01:00
2025-09-18 09:07:35 +02:00
2025-05-09 15:45:44 +02:00
2024-10-29 12:15:09 +01:00
2022-01-28 19:04:02 +01:00
2025-06-11 18:37:34 +02:00
2025-04-02 11:12:20 +02:00
2024-07-24 14:19:10 +02:00
2025-11-13 15:18:12 +01:00
2025-11-06 11:56:27 +01:00
2021-10-07 01:41:14 +02:00
2025-02-17 18:26:37 +01:00
2025-01-24 12:31:07 +01:00
2024-12-19 10:53:05 +01:00
2025-11-06 11:56:27 +01:00
2025-10-29 10:54:17 +01:00
2025-12-08 15:22:00 +01:00
2025-07-21 16:44:50 +02:00
2025-07-21 16:44:50 +02:00
2025-11-06 15:01:29 +01:00
2025-09-03 15:59:37 +02:00
2024-04-18 17:04:08 +02:00
2024-04-19 01:54:00 +02:00
2024-04-18 17:04:08 +02:00
2024-05-02 16:43:26 +02:00
2025-11-06 15:01:29 +01:00
2025-07-01 14:15:03 +02:00
2025-11-06 15:01:28 +01:00
2025-10-10 11:01:21 +02:00
2025-12-09 17:14:58 +01:00
2025-11-17 07:42:51 +01:00
2025-11-06 15:01:29 +01:00
2025-09-18 16:49:51 +02:00
2025-11-14 16:38:04 +01:00
2024-04-03 15:53:18 +02:00
2025-04-30 17:08:57 +02:00
2025-12-09 17:14:58 +01:00
2025-09-05 15:56:42 +02:00
2024-07-12 15:27:04 +02:00
2025-12-09 17:40:58 +01:00
2025-09-11 16:32:34 +02:00
2025-07-29 18:04:14 +02:00
2024-08-07 15:40:52 +02:00
2024-08-07 15:40:52 +02:00
2023-08-01 10:48:28 +02:00
2025-12-09 17:40:58 +01:00
2023-04-13 16:57:51 +02:00
2025-12-09 17:05:52 +01:00
2025-11-14 11:01:45 +01:00
2025-01-10 14:50:59 +01:00
2025-09-18 08:31:57 +02:00
2024-11-14 15:03:38 +01:00
2024-11-14 15:03:38 +01:00
2025-09-16 10:51:23 +02:00
2025-09-16 10:51:23 +02:00
2024-04-17 11:14:44 +02:00
2025-11-26 16:12:45 +01:00
2024-12-13 14:42:43 +01:00
2024-03-05 11:50:34 +01:00
2021-09-11 20:37:50 +02:00