haproxy/contrib
Willy Tarreau 54e917cfa1 MEDIUM: connection: remove useless flag CO_FL_DATA_RD_SH
This flag is both confusing and wrong. It is supposed to report the
fact that the data layer has received a shutdown, but in fact this is
reported by CO_FL_SOCK_RD_SH which is set by the transport layer after
this condition is detected. The only case where the flag above is set
is in the stream interface where CF_SHUTR is also set on the receiving
channel.

In addition, it was checked in the health checks code (while never set)
and was always test jointly with CO_FL_SOCK_RD_SH everywhere, except in
conn_data_read0_pending() which incorrectly doesn't match the second
time it's called and is fortunately protected by an extra check on
(ic->flags & CF_SHUTR).

This patch gets rid of the flag completely. Now conn_data_read0_pending()
accurately reports the fact that the transport layer has detected the end
of the stream, regardless of the fact that this state was already consumed,
and the stream interface watches ic->flags&CF_SHUTR to know if the channel
was already closed by the upper layer (which it already used to do).

The now unused conn_data_read0() function was removed.
2017-08-30 08:18:50 +02:00
..
base64 [CONTRIB] add base64rev-gen.c that was used to generate the base64rev table. 2010-01-31 19:14:07 +01:00
debug MEDIUM: connection: remove useless flag CO_FL_DATA_RD_SH 2017-08-30 08:18:50 +02:00
halog BUILD: don't use type "uint" which is not portable 2014-05-28 23:05:07 +02:00
ip6range BUILD: contrib: fix ip6range build on Centos 7 2016-11-22 11:50:51 +01:00
iprange MINOR: contrib: make the iprange tool grep for addresses 2012-12-13 00:11:02 +01:00
mod_defender BUG/MINOR: contrib/mod_defender: build fix 2017-07-19 14:35:24 +02:00
modsecurity BUG/MINOR: contrib/modsecurity: BSD build fix 2017-07-19 14:34:31 +02:00
netsnmp-perl [CONTRIB] Update Cacti Tempates 2010-10-30 19:04:36 +02:00
plug_qdisc CONTRIB: plug qdiscs: Plug queuing disciplines mini HOWTO. 2017-06-14 16:22:34 +02:00
selinux [CONTRIB] selinux policy for haproxy 2009-03-21 10:15:00 +01:00
spoa_example REORG: spoe: move spoe_encode_varint / spoe_decode_varint from spoe to common 2017-04-27 11:50:41 +02:00
systemd MAJOR: systemd-wrapper: get rid of the wrapper 2017-06-02 10:56:32 +02:00
tcploop CONTRIB: tcploop: add action "X" to execute a command 2017-05-03 06:58:53 +02:00
trace MINOR: add a new function call tracer for debugging purposes 2012-05-26 00:12:37 +02:00