mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2026-03-06 23:51:09 +01:00
4d7aefeee1
When providing multiple optional arguments with lua-load or lua-load-per-thread directives, arguments where pushed 1 by 1 to the stack using lua_pushstring() without checking if the stack could handle it. This could easily lead to program crash when providing too much arguments. I can easily reproduce the crash starting from ~50 arguments. Calling lua_checkstack() before pushing to the stack fixes the crash: According to lua.org, lua_checkstack() does some housekeeping and allow the stack to be expanded as long as some memory is available and the hard limit isn't reached. When no memory is available to expand the stack or the limit is reached, lua_checkstacks returns an error: in this case we force hlua_load_state() to return a meaningfull error instead of crashing. In practice though, cfgparse complains about too many words way before such event may occur on a normal system. TLDR: the ~50 arguments limitation is not an issue anymore. No backport needed, except if 'MINOR: hlua: Allow argument on lua-lod(-per-thread) directives' (ae6b568) is backported.
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)