mirror of
https://git.haproxy.org/git/haproxy.git/
synced 2025-09-21 05:41:26 +02:00
4070e4042a
The two timer handlers qc_process_timer() and qc_idle_timer_task() would inadvertently return NULL when they don't want to be requeued, instead of just returning the task itself. The effect of returning NULL for the scheduler is that it considers the task as freed, so it must not touch it anymore. As such, the TASK_F_RUNNING flag is never removed from these tasks, and when quic_conn_release() later tries to release these tasks using task_destroy(), the latter sees the RUNNING flag and just sets ->process to NULL, hoping that the scheduler will kill them on return, but there's no longer being executed so this never happens and they are leaked. Interestingly, this doesn't seem to happen as much when multi-queue is set to off, but it's likely because the tasks are being replaced and the first ones have already been woken up and leaked, while the latter might only trigger on a timeout or timer renewal. This should address github issue #2310. Thanks to @hpn0t0ad for the numerous traces that helped understand this sequence. This must be backported to 2.7 at least, and adapted for 2.6 (qc_idle_timer_task must return t there).
The HAProxy documentation has been split into a number of different files for ease of use. Please refer to the following files depending on what you're looking for : - INSTALL for instructions on how to build and install HAProxy - BRANCHES to understand the project's life cycle and what version to use - LICENSE for the project's license - CONTRIBUTING for the process to follow to submit contributions The more detailed documentation is located into the doc/ directory : - doc/intro.txt for a quick introduction on HAProxy - doc/configuration.txt for the configuration's reference manual - doc/lua.txt for the Lua's reference manual - doc/SPOE.txt for how to use the SPOE engine - doc/network-namespaces.txt for how to use network namespaces under Linux - doc/management.txt for the management guide - doc/regression-testing.txt for how to use the regression testing suite - doc/peers.txt for the peers protocol reference - doc/coding-style.txt for how to adopt HAProxy's coding style - doc/internals for developer-specific documentation (not all up to date)