Willy Tarreau 2830d282e5 DEBUG: task: simplify the caller recording in DEBUG_TASK ...

Instead of storing an index that's swapped at every call, let's use the
two pointers as a shifting history. Now we have a permanent "caller"
field that records the last caller, and an optional prev_caller in the
debug section enabled by DEBUG_TASK that keeps a copy of the previous
caller one. This way, not only it's much easier to follow what's
happening during debugging, but it saves 8 bytes in the struct task in
debug mode and still keeps it under 2 cache lines in nominal mode, and
this will finally be usable everywhere and later in profiling.

The caller_idx was also used as a hint that the entry was freed, in order
to detect wakeup-after-free. This was changed by setting caller to -1
instead and preserving its value in caller[1].

Finally, the operations were made atomic. That's not critical but since
it's used for debugging and race conditions represent a significant part
of the issues in multi-threaded mode, it seems wise to at least eliminate
some possible factors of faulty analysis.

2022-09-08 14:30:38 +02:00

..

haproxy

DEBUG: task: simplify the caller recording in DEBUG_TASK

2022-09-08 14:30:38 +02:00

import

MINOR: ebtree: add ebmb_lookup_shorter() to pursue lookups

2022-08-01 11:59:46 +02:00